Skip to content

Add NOT_SUPPORTED to OS' statues#3281

Merged
LeStarch merged 3 commits intodevelfrom
os-not-supported-status
Feb 26, 2025
Merged

Add NOT_SUPPORTED to OS' statues#3281
LeStarch merged 3 commits intodevelfrom
os-not-supported-status

Conversation

@kevin-f-ortega
Copy link
Collaborator

Related Issue(s) #3280
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Adding new enum

Rationale

Sometimes OSAL implementers need this

Testing/Review Recommendations

CI

Future Work

Note any additional work that will be done relating to this issue.

@kevin-f-ortega
Copy link
Collaborator Author

kevin-f-ortega commented Feb 26, 2025

I did not add NOT_SUPPORTED to OS classes that didn't have a Status enum

FwSizeType m_size; //!< Maximum message size
static Os::Mutex s_countLock; //!< Lock the count
static FwSizeType s_queueCount; //!< Count of the number of queues
QueueString m_name; //!< queue name

Check notice

Code scanning / CodeQL

Use of basic integral type Note

m_depth uses the basic integral type unsigned long rather than a typedef with size and signedness.
static Os::Mutex s_countLock; //!< Lock the count
static FwSizeType s_queueCount; //!< Count of the number of queues
QueueString m_name; //!< queue name
FwSizeType m_depth; //!< Queue depth

Check notice

Code scanning / CodeQL

Use of basic integral type Note

m_size uses the basic integral type unsigned long rather than a typedef with size and signedness.
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeStarch LeStarch merged commit a7f9bc7 into devel Feb 26, 2025
41 checks passed
LeStarch pushed a commit that referenced this pull request Feb 27, 2025
* adding not-supported status because sometimes it's useful to report not supported

* updating shadow enums to match actual enum
@thomas-bc thomas-bc deleted the os-not-supported-status branch February 27, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants