Merged
Conversation
deac557 to
d17eec0
Compare
LeStarch
approved these changes
Feb 25, 2025
…hen using pseudo-priority queues.
d17eec0 to
1d012d2
Compare
thomas-bc
approved these changes
Feb 26, 2025
LeStarch
pushed a commit
that referenced
this pull request
Feb 27, 2025
…hen using pseudo-priority queues. (#3268)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing priority for now in order to avoid incorrect message order when using pseudo-priority queues.
Change Description
Remove priority from ActiveLogger
Rationale
Issues in event queue-message order being out of order
Testing/Review Recommendations
Nominal CI
Future Work
Better handle queue priorities.