Double Lat/Lon/Alt for getPOSI#202
Merged
jason-watkins merged 19 commits intonasa:developfrom Apr 28, 2020
Merged
Conversation
Also fixed compiler warnings due to unsigned char for buffers. Changed to char.
Also fixed compiler error for timeval struct tv not defined for WIN32.
getPOSI now can interpret either float or double Lat/Lon/h messages. sendPOSI now sends double Lat/Lon/h messages. Also fixed integer conversion bug in sendCTRL.
Created a Python3 compatible version of Tests.py
Also changed actual [7] to a double in doGETPTEST to fix compiler warning
Also fixed compiler warning related to doGETDTEST on line 108
Contributor
Author
|
Now includes the fixes from #192 from master for merge into develop branch |
Contributor
|
Hi Norman, Just a note to let you know I'm looking this over. Not the top of my priority list unfortunately, but the changes basically look good. Hopefully we can get this merged this week. |
Contributor
Author
|
Hello, Jason,
Thanks for looking at it. Understand if you can't get to it right away. We all still have our day jobs to work. I've got another pull request or two to submit once this one gets merged. Those will be a bit simpler and are targeted at improvements to the terrain probe that was just added.
Just looked you up on Google and see you were at NASA Armstrong and now NASA Ames. I was Chief Engineer for X-48 that flew at Armstrong. Unfortunately, we finished the program a year before you got there. I am at Boeing in Huntington Beach and sometimes visit Ames. Would be great to meet up if we are ever in each other's area and the Covid thing is over.
Stay Safe!
Norm
…________________________________
From: Jason Watkins <notifications@github.com>
Sent: Monday, April 20, 2020 1:45 PM
To: nasa/XPlaneConnect <XPlaneConnect@noreply.github.com>
Cc: Norman Princen <nprincen@hotmail.com>; Author <author@noreply.github.com>
Subject: Re: [nasa/XPlaneConnect] Double Lat/Lon/Alt for getPOSI (#202)
Hi Norman,
Just a note to let you know I'm looking this over. Not the top of my priority list unfortunately, but the changes basically look good. Hopefully we can get this merged this week.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#202 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APHWJGCP2YBN3RZXUJQA2ETRNSX5PANCNFSM4MLVIP2A>.
|
jason-watkins
approved these changes
Apr 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues #180, #181, and #189 all discuss the problem of precision in receiving Latitude, Longitude, and Altitude from X-Plane using getPOSI. sendPOSI does provide for double Lat/Lon/Alt, but getPOSI was still using float. This pull request includes the required getPOSI fixes for the xpcPlugin, the C examples, the Python3 examples, and the C TestScripts. New Python3 test scripts have been added. These fixes maintain backwards compatibility with previous xpcPlugin and getPOSI by still being able to interpret the previous UDP packet formats, but without the better precision. I did not fix the Python, Java, or Matlab examples or tests. There are also additional bug fixes included to eliminate compiler errors and warnings I was receiving when building using the MSYS2 mingw-w64 gcc compiler on Windows. I also endorse the pull request #191 for fixing Python3 bugs as I needed to make those changes in addition to the ones in this pull request to get everything working in Python3.