Skip to content

Add cache for pooch on CI for Linux jobs#8235

Merged
brisvag merged 5 commits intonapari:mainfrom
Czaki:cache_pooch
Sep 3, 2025
Merged

Add cache for pooch on CI for Linux jobs#8235
brisvag merged 5 commits intonapari:mainfrom
Czaki:cache_pooch

Conversation

@Czaki
Copy link
Copy Markdown
Collaborator

@Czaki Czaki commented Aug 28, 2025

References and relevant issues

https://napari.zulipchat.com/#narrow/channel/298358-working-group-documentation/topic/docs.20CI

Description

To reduce the fragility of our test suite, add a cache. This will reduce the chance that the test is failing because of a network error.

@github-actions github-actions bot added the maintenance PR with maintance changes, label Aug 28, 2025
@Czaki Czaki added this to the 0.6.5 milestone Aug 28, 2025
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.08%. Comparing base (c751584) to head (0c665ee).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8235      +/-   ##
==========================================
+ Coverage   93.02%   93.08%   +0.05%     
==========================================
  Files         701      701              
  Lines       63177    63177              
==========================================
+ Hits        58769    58806      +37     
+ Misses       4408     4371      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

uses: actions/cache@0400d5f644dc74513175e3cd8d07132dd4860809 # v4
with:
path: ${{ env.POOCH_HOME }}
key: pooch-v
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: pooch-v
key: pooch-v1

?

But, why are we using a versioned key?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A need to manually invalidate the cache.
But Pooch already has hashes...

@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 29, 2025
@Czaki Czaki changed the title Add cache for pooch on CI Add cache for pooch on CI for Linux jobs Aug 29, 2025
@Czaki
Copy link
Copy Markdown
Collaborator Author

Czaki commented Sep 1, 2025

Once tox-dev/platformdirs#375 will be merged and released, the cache will also work on macOS.

But we can merge this, as it will increase test stability.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Sep 1, 2025
@TimMonko
Copy link
Copy Markdown
Contributor

TimMonko commented Sep 1, 2025

Once tox-dev/platformdirs#375 will be merged and released, the cache will also work on macOS.

But we can merge this, as it will increase test stability.

Looking good now. Should we open an issue to track, or will the cache work automatically?

@Czaki
Copy link
Copy Markdown
Collaborator Author

Czaki commented Sep 1, 2025

Looking good now. Should we open an issue to track, or will the cache work automatically?

It will happen automatically. There is a discussion about what to do for Windows.

@brisvag brisvag merged commit e650a01 into napari:main Sep 3, 2025
84 of 86 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Sep 3, 2025
@Czaki Czaki deleted the cache_pooch branch September 3, 2025 09:28
TimMonko pushed a commit to napari/docs that referenced this pull request Sep 3, 2025
# References and relevant issues

same as napari/napari#8235

# Description

Add cache for resources required for CI. In docs we are using only
Linux, so it will work for all workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PR with maintance changes,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants