Fix callback for File -> Open Folder... action#6935
Merged
jni merged 1 commit intonapari:mainfrom May 27, 2024
Merged
Conversation
Member
|
Nice catch! Thanks @DragaDoncila ! |
psobolewskiPhD
approved these changes
May 26, 2024
Member
|
I agree that there needs to be better testing for the app-model stuff, but getting this obvious fix in is just good, so lets not let perfect block it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6935 +/- ##
==========================================
- Coverage 92.49% 92.43% -0.06%
==========================================
Files 612 612
Lines 55169 55169
==========================================
- Hits 51027 50997 -30
- Misses 4142 4172 +30 ☔ View full report in Codecov by Sentry. |
lucyleeow
approved these changes
May 26, 2024
Contributor
lucyleeow
left a comment
There was a problem hiding this comment.
Lgtm.
I'll have a think about the tests.
Closed
andy-sweet
pushed a commit
to andy-sweet/napari
that referenced
this pull request
May 28, 2024
# References and relevant issues Closes napari#6934 # Description Incorrect callback was being used for the `Open Folder` action. This PR fixes it. We need a testing framework for the actions and menus @lucyleeow, which we knew, but maybe we should prioritize ahead of converting the layer actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Closes #6934
Description
Incorrect callback was being used for the
Open Folderaction. This PR fixes it. We need a testing framework for the actions and menus @lucyleeow, which we knew, but maybe we should prioritize ahead of converting the layer actions.