Add warning notification when connectivity errors occur in when opening the plugin manager#6931
Conversation
|
Hi @psobolewskiPhD, added you as reviewer since you opened the original issue :) |
|
Thanks @goanpeca!
Is this something that should be revisited? (ie how hard would it be to pull this out too?) |
|
Hi @jni
Something to consider indeed, I think the only "user" of the file being modified in this PR is the napari-plugin-manager, so we could perhaps pull it out. |
And can we imagine any other users? To me it is indeed very weird that napari would contact conda-forge — to use the analogy motivating the original pull-out, it would be as if matplotlib was contacting conda-forge. That would be surprising! |
Well technically we are pinging
I cant think of any at the moment, but perhaps I need others to chime in here 🤔 |
Ah! Right! That's indeed a little different. I'm not sure but my instinct still says transplant it. |
|
Without the plugin manager, can |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6931 +/- ##
==========================================
- Coverage 92.48% 92.42% -0.06%
==========================================
Files 612 612
Lines 55165 55171 +6
==========================================
- Hits 51018 50991 -27
- Misses 4147 4180 +33 ☔ View full report in Codecov by Sentry. |
|
Did a quick search for usage of npe2api module, and indeed it does not seem to be used anywhere inside napari.
nope at the moment :) Now in the spirit of making less PRs, any chance we could get this merged here 🙈 so I can then proceed to transplant it? |
Seems reasonable to me. Fix it, then port it over. |
|
Any suggestions on the current text I used are welcome:
I took it loosely from what @psobolewskiPhD wrote on the original issue, but perhaps it could be made more clear/concise :) |
|
Created this napari/napari-plugin-manager#33 to track "transplants" |
|
Thanks @jni! Working on the transplant now :) |
…ng the plugin manager (napari#6931) Fixes napari/napari-plugin-manager#26 # Description Catches connectivity errors when fetching for plugin information when opening the plugin manager. Although the issue lives in the plugin manager repo, the code that fetches the code still lives in napari, hence with the PR seem to be better resolved on this side. # Result ## Before this PR  ## With this PR  The warning reads: >There seems to be an issue with network connectivity. Remote plugins cannot be installed, only local ones.
Fixes napari/napari-plugin-manager#26
Description
Catches connectivity errors when fetching for plugin information when opening the plugin manager.
Although the issue lives in the plugin manager repo, the code that fetches the code still lives in napari, hence with the PR seem to be better resolved on this side.
Result
Before this PR
With this PR
The warning reads: