Fix typing checks in PRs#6230
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6230 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 583 583
Lines 51363 51364 +1
=======================================
+ Hits 47050 47054 +4
+ Misses 4313 4310 -3
|
DragaDoncila
left a comment
There was a problem hiding this comment.
@andy-sweet agree returning the dialog would be nice. Definitely approving for now though so we can get PRs green again
|
There seem to be a GitHub bug that
I'm leaning to merge even if "Label and milestone checker" is read to fix other PRs. |
Made an issue #6235 so we can keep track |
Now it works. maybe some problem with their internal Api at this time
We check milestones based on event payload, not rest API requests. It restarted with an identical event payload. So restart will not help in such case.
All green. I will merge in few hours. |
Exceptionally as this is a hotfix, I'm going to merge to unblock/rebase other failing PRs. |
* main: Fix typing checks in PRs (napari#6230)
#6203 was merged without updating the latest changes from
mainand now the typing checks in PRs fails due to updates innapari.components. We don't run those changes onmain, though maybe we should given that we don't requires PR branches to be up-to-date before merging (only that git reports no conflicts).This PR fixes the typing failure by casting the type away from the possible value of
None, which is a side-effect of calling_open_preferences_dialog. An alternative fix is to have_open_preferences_dialogto returnPreferencesDialog, which I like but felt like a bigger change than needed. Of course, we can also use# type: ignore, but I don't there's a need here.