Rename dependent_blocks/dependents_confirmed to block_dependencies/dependencies_confirmed#5027
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Feb 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames two ledger APIs to use correct “dependency” terminology and updates all call sites and tests accordingly, improving clarity around block prerequisite checks during confirmation, voting, and scheduling.
Changes:
- Renamed
dependent_blocks→block_dependenciesanddependents_confirmed→dependencies_confirmed(declaration + definition + usages). - Updated node components (vote generator, schedulers) to use the new API names.
- Updated core tests and improved/relocated header documentation for dependency and priority helpers.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| nano/secure/ledger.hpp | Replaces old method declarations with block_dependencies / dependencies_confirmed and adds clearer Doxygen comments. |
| nano/secure/ledger.cpp | Renames implementations and updates confirmation logic to use new dependency naming. |
| nano/node/vote_generator.cpp | Updates vote eligibility logic to call dependencies_confirmed. |
| nano/node/scheduler/priority.cpp | Uses dependencies_confirmed before bucket prioritization. |
| nano/node/scheduler/hinted.cpp | Updates DFS activation logic to use dependencies_confirmed / block_dependencies. |
| nano/core_test/request_aggregator.cpp | Updates test to call dependencies_confirmed. |
| nano/core_test/node.cpp | Updates test assertions/comment to dependency terminology. |
| nano/core_test/ledger.cpp | Renames tests and updates assertions for dependencies_confirmed. |
| nano/core_test/active_elections.cpp | Updates test assertion to call dependencies_confirmed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results for Commit d7c79baPull Request 5027: Results Test Case Results
Last updated: 2026-02-11 23:48:45 UTC |
6b0b230 to
6f32b4b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…pendencies_confirmed
065fff0 to
d7c79ba
Compare
simpago
added a commit
to rsnano-node/rsnano-node
that referenced
this pull request
Mar 20, 2026
…pendencies_confirmed (nanocurrency#5027)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both functions use "dependent" when they should use "dependency".