Unlimited backlog when bootstrapping#4922
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom Jul 5, 2025
Merged
Conversation
493b4a6 to
262dd95
Compare
Test Results for Commit e275c26Pull Request 4922: Results Test Case Results
Last updated: 2025-06-28 09:46:17 UTC |
262dd95 to
e275c26
Compare
pwojcikdev
added a commit
that referenced
this pull request
Jul 8, 2025
# Conflicts: # nano/secure/ledger.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding bounded backlog significantly decreased bootstrap performance due to the fixed 100k limit for unconfirmed blocks. This fixe limit reduces effectiveness of optimistic elections. This PR introduces a heuristic to dynamically increase the bounded backlog limit until the configured bootstrap block count is reached.
One caveat with this approach is that over time, the live network block count will drift from the preconfigured count (as of V28, it is 207107949).