Ledger rep weights consistency checks#4914
Merged
pwojcikdev merged 4 commits intonanocurrency:developfrom Jun 22, 2025
Merged
Conversation
4718c1d to
b9a252b
Compare
b9a252b to
7be2c95
Compare
Test Results for Commit 7be2c95Pull Request 4914: Results Test Case Results
Last updated: 2025-06-06 08:49:43 UTC |
pwojcikdev
added a commit
that referenced
this pull request
Jun 23, 2025
Ledger rep weights consistency checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fail-fast consistency check for the representative-weight map, one of the node’s most critical components. Any divergence triggers an assert that aborts the process immediately and dumps information to the log.
This is the first part of an effort to protect against silent ledger-database corruption.
Why it matters
Silent corruption can lead to incorrect quorum decisions. A stale or incorrect rep-weight map undermines consensus.
Detecting discrepancies the moment they appear keeps the blast radius small.
We have historically observed database corruption on nodes running on the RocksDB backend. It is important to remember that RocksDB is still considered experimental, so no production services should rely on it.