Incremental backoff for local_block_broadcaster#4662
Merged
pwojcikdev merged 8 commits intonanocurrency:developfrom Jul 3, 2024
Merged
Incremental backoff for local_block_broadcaster#4662pwojcikdev merged 8 commits intonanocurrency:developfrom
local_block_broadcaster#4662pwojcikdev merged 8 commits intonanocurrency:developfrom
Conversation
78cfbc3 to
42f03b1
Compare
42f03b1 to
dbb1751
Compare
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jul 2, 2024
…ck_broadcaster`
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jul 2, 2024
…ck_broadcaster`
clemahieu
reviewed
Jul 2, 2024
clemahieu
approved these changes
Jul 2, 2024
Contributor
|
Minor question about the max size but otherwise LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements incremental backoff for block rebroadcasting. Previously block rebroadcasts happened every 60 seconds. This changes it, so that early on rebroadcasts happen more frequently, with 3 second interval increase. Ie. first rebroadcast happens after 3 seconds, second after 9, third after 18 etc.
Additionally there are improvements that were necessary to implement the above: avoiding unnecessary locking and config cleanup.