More vote cache optimizations#4629
Merged
pwojcikdev merged 8 commits intonanocurrency:developfrom May 19, 2024
Merged
Conversation
clemahieu
approved these changes
May 18, 2024
Contributor
clemahieu
left a comment
There was a problem hiding this comment.
Added comment for vote_router::vote 'filter' parameter as it took me a bit to understand what it's doing.
Contributor
|
An increase in throughput can be clearly seen with these changes, especially when the 255votes/message feature is turned on as you can see here : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #4627 and optimizes insertion of votes into the vote cache and fixes a significant performance regression in
trigger_vote_cachefunction.