Address performance regression in vote_cache::top#4627
Merged
pwojcikdev merged 3 commits intonanocurrency:developfrom May 19, 2024
Merged
Address performance regression in vote_cache::top#4627pwojcikdev merged 3 commits intonanocurrency:developfrom
pwojcikdev merged 3 commits intonanocurrency:developfrom
Conversation
pwojcikdev
approved these changes
May 17, 2024
Contributor
There was a problem hiding this comment.
I can't remember why I removed the by tally index, seems to make no sense.
EDIT:
Okay, so tally () is not a constant time function:
return std::accumulate (voters.begin (), voters.end (), nano::uint128_t{ 0 }, [] (auto sum, auto const & item) {
return sum + item.weight;
});
Did you measure that the additional overhead on each insertion is worth the speedup during lookup? In any case, it's possible to implement some kind of smart tally caching to alleviate this issue and have both fast insertion and top lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert c734caf which removed loop short-circuit checking for top voted-for elections.
Eliminate duplicate expression evaluation.
Use deque rather than vector for results to reduce backing reallocation.