Remove assert for null block deserialization#4241
Merged
pwojcikdev merged 1 commit intonanocurrency:developfrom May 31, 2023
Merged
Remove assert for null block deserialization#4241pwojcikdev merged 1 commit intonanocurrency:developfrom
pwojcikdev merged 1 commit intonanocurrency:developfrom
Conversation
clemahieu
approved these changes
May 31, 2023
thsfs
added a commit
to thsfs/nano-node
that referenced
this pull request
May 31, 2023
* Moving from CentOS namig to RHEL compatible * Remove unused build_prep scripts * Update to use RockyLinux 8 as RHEL 8 compatible base Also applies changes to build C++20 (Starting on V25.0) * Add a workflow for beta RPM builds Also fixes the old nanocurrency-beta to build on RockyLinux 8. * Fix nano_node binary name for beta RPM service installation * Blockprocessor stall workaround (nanocurrency#4240) * Remove assert for null block deserialization (nanocurrency#4241) * Bump Qt dep version for Windows build --------- Co-authored-by: Piotr Wójcik <3044353+pwojcikdev@users.noreply.github.com>
clemahieu
pushed a commit
that referenced
this pull request
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nano::deserialize_blockalready properly handles the case where deserialized block type isblock_type::not_a_blockor invalid, however it triggers a debug assertion for those cases. This is not necessary, since this is a normal condition that happens during normal node operation (eg. during bootstrapping). It also makes it impossible to run a debug node build on the live network.