Changes the semantics of election::confirmed and clean up several unit tests#4200
Merged
clemahieu merged 1 commit intonanocurrency:developfrom Mar 28, 2023
Merged
Conversation
dsiganos
reviewed
Mar 28, 2023
4d6e67f to
b52fa93
Compare
…s durably confirmed on disk, rather than simply being confirmed in memory. This was causing subtle race conditions or unnecessary extra checking to ensure the confirmation has been committed to disk. Modifies tests: active_transactions.dropped_cleanup active_transactions.inactive_votes_cache_election_start active_transactions.republish_winner confirmation_height.conflict_rollback_cemented election.quorum_minimum_confirm_success election.quorum_minimum_update_weight_before_quorum_checks node.rollback_gap_source rpc.confirmation_active vote_processor.invalid_signature Rewriting test to use a block that is not confirmed on disk. Cleaning up confirmation_height.conflict_rollback_cemented and reduce complexity. Cleaning up election.quorum_minimum_confirm_success and fixing race condition where confirmation happens asynchronously. Fixing race condition in election.quorum_minimum_update_weight_before_quorum_checks when checking asynchronous election confirmation. Cleaning up and simplifying node.rollback_gap_source Removing some test calls to block_processor::flush which is being phased out.
b52fa93 to
0e580f8
Compare
pwojcikdev
added a commit
to pwojcikdev/nano-node
that referenced
this pull request
Apr 18, 2023
… block is durably confirmed on disk, rather than simply being confirmed in memory. This was causing subtle race conditions or unnecessary extra checking to ensure the confirmation has been committed to disk. (nanocurrency#4200)" This reverts commit fde815f.
clemahieu
added a commit
to clemahieu/nano-node
that referenced
this pull request
Apr 24, 2023
…hich is now directly read within election::confirmed as of nanocurrency#4200
pwojcikdev
added a commit
to pwojcikdev/nano-node
that referenced
this pull request
Jun 20, 2023
… block is durably confirmed on disk, rather than simply being confirmed in memory. This was causing subtle race conditions or unnecessary extra checking to ensure the confirmation has been committed to disk. (nanocurrency#4200)" This reverts commit fde815f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the semantics of election::confirmed to return if the block is durably confirmed on disk, rather than simply being confirmed in memory. This was causing subtle race conditions or unnecessary extra checking to ensure the confirmation has been committed to disk.
Rewriting test to use a block that is not confirmed on disk.
Cleaning up confirmation_height.conflict_rollback_cemented and reduce complexity.
Cleaning up election.quorum_minimum_confirm_success and fixing race condition where confirmation happens asynchronously.
Fixing race condition in election.quorum_minimum_update_weight_before_quorum_checks when checking asynchronous election confirmation.
Cleaning up and simplifying node.rollback_gap_source Removing some test calls to block_processor::flush which is being phased out.