Skip to content

Add comment for NANO_DEFAULT_PEER environment variable#4073

Merged
dsiganos merged 2 commits intonanocurrency:developfrom
qwahzi:patch-1
Jan 27, 2023
Merged

Add comment for NANO_DEFAULT_PEER environment variable#4073
dsiganos merged 2 commits intonanocurrency:developfrom
qwahzi:patch-1

Conversation

@qwahzi
Copy link
Copy Markdown
Collaborator

@qwahzi qwahzi commented Jan 25, 2023

Adding documentation to the config-node.toml generator for the NANO_DEFAULT_PEER environment variable override, per #3656

Adding documentation to the config-node.toml generator for the NANO_DEFAULT_PEER environment variable override
Update preconfigured_peers comment in nodeconfig.cpp
qwahzi added a commit to qwahzi/nano-docs-1 that referenced this pull request Jan 25, 2023
Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
thsfs pushed a commit to nanocurrency/nano-docs that referenced this pull request Jan 26, 2023
* Add NANO_DEFAULT_PEER documentation

Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656

* Update NANO_DEFAULT_PEER comments in build-options.md

Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
Copy link
Copy Markdown
Contributor

@pwojcikdev pwojcikdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We still have a few of those environment variables not documented yet, some have the NANO_TEST_* prefix, should probably be renamed to simply NANO_* for consistency. Of course this is just an idea for the future

@dsiganos
Copy link
Copy Markdown
Contributor

I believe that the NANO_TEST_ variables are a special subgroup of variables used for creating custom networks. Terrible naming though.

@dsiganos dsiganos merged commit 1036804 into nanocurrency:develop Jan 27, 2023
@qwahzi qwahzi added this to the V25.0 milestone Jan 27, 2023
@qwahzi qwahzi added documentation This item indicates the need for or supplies updated or expanded documentation non-functional change labels Jan 27, 2023
SmartNodeX added a commit to SmartNodeX/nano-docs that referenced this pull request Sep 16, 2025
* Add NANO_DEFAULT_PEER documentation

Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656

* Update NANO_DEFAULT_PEER comments in build-options.md

Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
ethanWalker89 added a commit to ethanWalker89/nano-docs that referenced this pull request Sep 23, 2025
* Add NANO_DEFAULT_PEER documentation

Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656

* Update NANO_DEFAULT_PEER comments in build-options.md

Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
crypto-phantomb6u7 added a commit to crypto-phantomb6u7/nano-docs that referenced this pull request Sep 28, 2025
* Add NANO_DEFAULT_PEER documentation

Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656

* Update NANO_DEFAULT_PEER comments in build-options.md

Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This item indicates the need for or supplies updated or expanded documentation non-functional change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants