Allow overriding initial peering DNS by environment variable#3656
Merged
dsiganos merged 2 commits intonanocurrency:developfrom Jan 11, 2022
Merged
Allow overriding initial peering DNS by environment variable#3656dsiganos merged 2 commits intonanocurrency:developfrom
dsiganos merged 2 commits intonanocurrency:developfrom
Conversation
The initial peering DNS for beta network is peering-beta.nano.org. This commit allows to set NANO_BETA_PEER_NETWORK to override it. This allows for more flexibility when running private test networks.
Collaborator
|
@dsiganos In what scenario is using the beta network with custom peering DNS preferred over the test network which already allows this customization? |
Contributor
Author
|
If we wanted to run SPAM attack tests then they are easier on beta network than on test network due to reduced difficulty. |
Contributor
Author
|
After discussion, it was decided to:
|
…l networks (live, beta, test) We want to have one environment variable to override the default preconfigured peer in all networks cases (live, beta and test). The name thus needs renaming to remove TEST from its name. Since we are renaming it, we also take the opportunity to improve the name to something more descriptive, NANO_DEFAULT_PEER.
clemahieu
approved these changes
Jan 11, 2022
Collaborator
|
Just noting that there are no documentation changes to be considered for this. |
qwahzi
added a commit
to qwahzi/nano-docs-1
that referenced
this pull request
Jan 25, 2023
Add NANO_DEFAULT_PEERS documentation per nanocurrency/nano-node#3656
qwahzi
added a commit
to qwahzi/nano-docs-1
that referenced
this pull request
Jan 25, 2023
Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656
This was referenced Jan 25, 2023
thsfs
pushed a commit
to nanocurrency/nano-docs
that referenced
this pull request
Jan 26, 2023
* Add NANO_DEFAULT_PEER documentation Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656 * Update NANO_DEFAULT_PEER comments in build-options.md Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
SmartNodeX
added a commit
to SmartNodeX/nano-docs
that referenced
this pull request
Sep 16, 2025
* Add NANO_DEFAULT_PEER documentation Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656 * Update NANO_DEFAULT_PEER comments in build-options.md Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
ethanWalker89
added a commit
to ethanWalker89/nano-docs
that referenced
this pull request
Sep 23, 2025
* Add NANO_DEFAULT_PEER documentation Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656 * Update NANO_DEFAULT_PEER comments in build-options.md Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
crypto-phantomb6u7
added a commit
to crypto-phantomb6u7/nano-docs
that referenced
this pull request
Sep 28, 2025
* Add NANO_DEFAULT_PEER documentation Add NANO_DEFAULT_PEER documentation per nanocurrency/nano-node#3656 * Update NANO_DEFAULT_PEER comments in build-options.md Update NANO_DEFAULT_PEER comments in build-options.md, per nanocurrency/nano-node#4073 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial peering DNS is peering.nano.org.
This commit allows to set NANO_DEFAULT_PEER to override it.
This allows for more flexibility when running private test networks.