Return unopened accounts#4066
Merged
dsiganos merged 5 commits intonanocurrency:developfrom Jan 25, 2023
Merged
Conversation
pwojcikdev
previously approved these changes
Jan 22, 2023
Contributor
pwojcikdev
left a comment
There was a problem hiding this comment.
It doesn't make sense to return an error if one of the accounts is not opened yet, it's unfortunate it wasn't caught during testing. Thanks for the PR!
Contributor
Author
|
I targeted this PR against the develop branch but maybe v24 should get a patched version as well? |
Contributor
|
When it gets merged into develop it can be cherry picked into v24 branch, so it's fine. |
Exxenoz
reviewed
Jan 23, 2023
dsiganos
added a commit
to dsiganos/nano-node
that referenced
this pull request
Jan 25, 2023
* Remove account check error and return unopened account balance * Update unit tests for accounts_balances * Remove unneeded account_info variable * Improve the comments a little * Unit test case for unopened account with receivables Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
dsiganos
added a commit
that referenced
this pull request
Jan 25, 2023
* Remove account check error and return unopened account balance * Update unit tests for accounts_balances * Remove unneeded account_info variable * Improve the comments a little * Unit test case for unopened account with receivables Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
dsiganos
added a commit
that referenced
this pull request
Jan 27, 2023
* Remove account check error and return unopened account balance * Update unit tests for accounts_balances * Remove unneeded account_info variable * Improve the comments a little * Unit test case for unopened account with receivables Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
Contributor
|
Documentation changes for V24/V25: nanocurrency/nano-docs#670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #4064
accounts_balancesRPC was changed in 580c3c1That also changed the response of unopened accounts into an error message
The response of
accounts_balancesshould mimicaccount_balanceand this PR makesaccounts_balancesreturn the actual balance values of unopened accounts the way it did before 580c3c1Invalid accounts will still return an error