Specify whether bootstrap pull should start at block hash or account#4018
Conversation
|
Is this something that would be better as a header flag? |
3e143ac to
7c95789
Compare
|
I do not agree with creating an enum for something that has only 2 states. |
|
@dsiganos I don't understand how enum conflicts with using flags? IMHO it's much better code style to define you flags as an enum (in contrast to defining const ints, C style). One of the first links I found on the internet you might want to check out, specifically the section on |
|
@pwojcikdev This is mostly stylistic disagreement so no big deal if we go one way or another. |
…4018) * Specify whether pull should start at block hash or account * Specify account info request target type
There are accounts with the same hash as another block in our live ledger. That creates ambiguity and makes it impossible to pull those account chains. This PR removes that ambiguity by always specifying whether requested hash is a block or account.