confirmation_height_clear cli account param#3836
Merged
dsiganos merged 3 commits intonanocurrency:developfrom Jun 24, 2022
Merged
confirmation_height_clear cli account param#3836dsiganos merged 3 commits intonanocurrency:developfrom
dsiganos merged 3 commits intonanocurrency:developfrom
Conversation
thsfs
previously approved these changes
Jun 23, 2022
Contributor
|
Sent a fix to the line I mentioned earlier, there is also the |
Contributor
|
@dsiganos , could you double check and get this merged if you approve? |
dsiganos
reviewed
Jun 23, 2022
nano/node/cli.cpp
Outdated
| auto transaction (node.node->store.tx_begin_write ()); | ||
| reset_confirmation_heights (transaction, node.node->network_params.ledger, node.node->store); | ||
| std::cout << "Confirmation heights of all accounts (except genesis which is set to 1) are set to 0" << std::endl; | ||
| std::cerr << "confirmation_height_clear command requires one <account> option\n"; |
Contributor
There was a problem hiding this comment.
It could also say: "or 'any' to clear all accounts.
Contributor
There was a problem hiding this comment.
Improved this and also the help message to the --confirmation_height_clear option.
dsiganos
previously approved these changes
Jun 23, 2022
- Improve the error message to say the account can be 'all' - Improve the confirmation_height_clear help message to inform the value 'all' can be passed to clear all accounts
dsiganos
approved these changes
Jun 24, 2022
Contributor
|
Thanks @JerzyStanislawski ! |
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jul 9, 2022
* confirmation_height_clear cli account param * Add back missing password option * Improve the error/help messages to the required account option - Improve the error message to say the account can be 'all' - Improve the confirmation_height_clear help message to inform the value 'all' can be passed to clear all accounts Co-authored-by: Thiago Silva <thiago@nano.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make account argument required for confirmation_height_clear cli command.
Issue reference: #3831
resolves #3831