Introduce ledger.rollback_failed stat counter#3746
Merged
theohax merged 2 commits intofix-unit-test-confirmation_height.conflict_rollback_cementedfrom Apr 6, 2022
Merged
Conversation
Contributor
|
This is missing the string name for the enumeration: /Users/clemahieu/nano-node.src/nano/lib/stats.cpp:544:10: warning: enumeration value 'rollback_failed' not handled in switch [-Wswitch] |
39334ba to
6bc31d3
Compare
c3740c8 to
1502a73
Compare
1502a73 to
b4bfc6e
Compare
clemahieu
approved these changes
Apr 6, 2022
de7c26f
into
fix-unit-test-confirmation_height.conflict_rollback_cemented
theohax
added a commit
that referenced
this pull request
Apr 6, 2022
* Added lots of comments and made some improvements to conflict_rollback_cemented * Introduce `ledger.rollback_failed` stat counter (#3746) * Use ledger.rollback_failed in confirmation_height.conflict_rollback_cemented Co-authored-by: Dimitrios Siganos <dimitris@siganos.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, use that counter in
confirmation_height.conflict_rollback_cementedunit test.Based off of #3745