Skip to content

Fix unit test confirmation_height.election_winner_details_clearing#3688

Closed
theohax wants to merge 2 commits intodevelopfrom
fix-confirmation_height.election_winner_details_clearing-unit-test
Closed

Fix unit test confirmation_height.election_winner_details_clearing#3688
theohax wants to merge 2 commits intodevelopfrom
fix-confirmation_height.election_winner_details_clearing-unit-test

Conversation

@theohax
Copy link
Copy Markdown
Contributor

@theohax theohax commented Jan 24, 2022

One more unit test fix. Updating the linked #3608 issue as well.

@theohax theohax added bug unit test Related to a new, changed or fixed unit test labels Jan 24, 2022
@theohax
Copy link
Copy Markdown
Contributor Author

theohax commented Jan 24, 2022

node.vote_republish failed in the CI, but it's already on my to-fix-soon list, so I won't disable it.

@zhyatt zhyatt added this to the V24.0 milestone Jan 24, 2022
@theohax theohax self-assigned this Jan 26, 2022
clemahieu
clemahieu previously approved these changes Feb 3, 2022
@clemahieu clemahieu force-pushed the fix-confirmation_height.election_winner_details_clearing-unit-test branch from 3a659de to 651d584 Compare February 3, 2022 13:45
@theohax
Copy link
Copy Markdown
Contributor Author

theohax commented Feb 15, 2022

Looks like confirmation_height.election_winner_details_clearing fix got merged already (in #3679), additionally there's one more fix from @dsiganos in #3741, therefore closing this one.

@theohax theohax closed this Feb 15, 2022
@theohax theohax deleted the fix-confirmation_height.election_winner_details_clearing-unit-test branch February 15, 2022 15:14
@zhyatt zhyatt removed this from the V24.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug unit test Related to a new, changed or fixed unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test confirmation_height.election_winner_details_clearing intermittently failing

3 participants