Fix confirmation_height.election_winner_details_clearing#3741
Merged
dsiganos merged 1 commit intonanocurrency:developfrom Feb 15, 2022
Merged
Conversation
There is a race condition between a block getting confirmed and setting of statistics counters. In this case, the counter is incremented in an observer callback that is executed after the block is confirmed. One could say that the problem is that the stat counters should updated before the block is confirmed but I think that is unrealistic to achieve and possibly not even the right approach. Converting the check to an ASSERT_TIMELY fixes the problem. It seems likely that other test cases will have this problem too.
theohax
approved these changes
Feb 15, 2022
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition between a block getting confirmed and setting
of statistics counters. In this case, the counter is incremented in an
observer callback that is executed after the block is confirmed.
One could say that the problem is that the stat counters should updated
before the block is confirmed but I think that is unrealistic to achieve
and possibly not even the right approach.
Converting the check to an ASSERT_TIMELY fixes the problem.
It seems likely that other test cases will have this problem too.