change SERIAL_DEBUG into RF24NETWORK_DEBUG#228
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 6cd1c28..42b549c 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -637,2 +637,2 @@ uint16_t ESBNetwork<radio_t>::read(RF24NetworkHeader& header, void* message, uin
- "\n\r"),
- millis(), header.toString()));
+ "\n\r"),
+ millis(), header.toString()));
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Memory usage change @ bed8b9e
Click for full report table
Click for full report CSV |
Member
Author
|
Its a good thing you requested this change. I forgot that this lib was relying on RF24's |
TMRh20
approved these changes
Jun 15, 2024
Member
Author
|
cherry picked to v1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see nRF24/RF24#980