Skip to content

Fix for Multicast to level 4#227

Merged
TMRh20 merged 1 commit intomasterfrom
Multicast_Lvl_4
Jun 5, 2024
Merged

Fix for Multicast to level 4#227
TMRh20 merged 1 commit intomasterfrom
Multicast_Lvl_4

Conversation

@TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jun 5, 2024

#226

  • Define NETWORK_MULTICAST_ADDRESS_LEVEL_2 and NETWORK_MULTICAST_ADDRESS_LEVEL_4 in RF24Network.cpp
  • Add the above to valid addresses in is_valid_address();

#226
- Define NETWORK_MULTICAST_ADDRESS_LEVEL_2 and NETWORK_MULTICAST_ADDRESS_LEVEL_4
- Add the above to valid addresses in `is_valid_address();`
@TMRh20 TMRh20 requested a review from 2bndy5 June 5, 2024 10:18
@TMRh20 TMRh20 added the bug label Jun 5, 2024
@2bndy5
Copy link
Member

2bndy5 commented Jun 5, 2024

Does net level 3 not have any problems? Or are we only compensating for known/reported problems?

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 5, 2024

Hmm, this library IS a bit confusing. Level 3 is 0100 or the default NETWORK_MULTICAST_ADDRESS, so it is accounted for. The only thing I'm curious about is potential conflicts between multicast address level 1 (01) and assigned address at RF24Network address 01 as they are the same digit... I haven't had a chance to look into it at all.

@2bndy5
Copy link
Member

2bndy5 commented Jun 5, 2024

Oh right. I was confusing 04444 with NETWORK_MULTICAST_ADDRESS. Obviously, its been a while since I actually looked at the code in depth.

As for the 01 conflict, we could use a reserved bit in the header to distinguish between multicast or direct writes.

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 5, 2024

As for the 01 conflict, we could use a reserved bit in the header to distinguish between multicast or direct writes.

Is it needed? I don't quite know yet. I also thought about just changing the multicast level addresses to 06... or 07, 070, 0700, 07000

@TMRh20 TMRh20 merged commit 36e35c4 into master Jun 5, 2024
@TMRh20 TMRh20 deleted the Multicast_Lvl_4 branch June 5, 2024 23:52
2bndy5 pushed a commit that referenced this pull request Jun 11, 2024
#226
- Define NETWORK_MULTICAST_ADDRESS_LEVEL_2 and NETWORK_MULTICAST_ADDRESS_LEVEL_4
- Add the above to valid addresses in `is_valid_address();`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants