Added StyleCop.Analyzers#143
Merged
milkshakeuk merged 37 commits intonHapiNET:masterfrom Feb 17, 2021
Merged
Conversation
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
milkshakeuk
reviewed
Feb 11, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
milkshakeuk
reviewed
Feb 14, 2021
7b857b9 to
329df8e
Compare
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
milkshakeuk
reviewed
Feb 16, 2021
This comment has been minimized.
This comment has been minimized.
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
milkshakeuk
reviewed
Feb 17, 2021
…api.sln Updates to resolve comments from PR
Unit Test Results 5 files 48 suites 8s ⏱️ Results for commit 30658d2. |
milkshakeuk
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #138
The main goal of this PR is to add code styling rules and fix any violations.
Added the latest version of StyleCop.Analyzers to each main project, including a
stylecop.jsonfile and a default.editorconfigruleset.Have kept the default set of SA rules with the exception of the following:
I have also temporarily disabled documentation rules (these will be tackeled under a separate issue) and obsolete code warnings (until the model code can be regenerated to use the case-corrected methods.
Fixed nearly all rule violations accross:
I have done limited refactoring and spelling correction, but I think that this should be addressed more thoroughly under a separate issue.