Merged
Conversation
Closed
milkshakeuk
reviewed
Jan 30, 2021
Member
milkshakeuk
left a comment
There was a problem hiding this comment.
I think there a couple here which might need amending, the others are more related to incorrect code examples which this ticket is not trying to resolve.
Collaborator
Author
|
@milkshakeuk - thanks for reviewing. I think i've covered those off. |
milkshakeuk
reviewed
Feb 1, 2021
milkshakeuk
approved these changes
Feb 1, 2021
Member
milkshakeuk
left a comment
There was a problem hiding this comment.
@AMCN41R Thanks for this.
ddc7ae7 to
dd566dc
Compare
dd566dc to
0f01237
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes XML comment warnings in
NHapi.BaseandNHapi.SourceGenerationprojects.issue: #128