tests: Fix ip_wins_over_custom flakiness#4047
Merged
Conversation
The purpose of these tests is to show that the biasing mechanism works. Maybe 100ms is too low to make this work reliably.
flub
approved these changes
Mar 24, 2026
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4047/docs/iroh/ Last updated: 2026-03-24T12:25:16Z |
We really don't care. This is just about the selection. Now it would only fail if no ip transport is available at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase the bias so we can't accidentally get a wrong selection because IP transport is super slow.
Breaking Changes
None
Notes & open questions
Should I make this a minute?
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme