Skip to content

fix(iroh)!: Don't publish IP addresses from PkarrPublisher by default#4012

Merged
dignifiedquire merged 17 commits intomainfrom
matheus23/fix-ip-publish
Mar 16, 2026
Merged

fix(iroh)!: Don't publish IP addresses from PkarrPublisher by default#4012
dignifiedquire merged 17 commits intomainfrom
matheus23/fix-ip-publish

Conversation

@matheus23
Copy link
Copy Markdown
Member

@matheus23 matheus23 commented Mar 12, 2026 •
edited
Loading

Description

Partially reverts #3987 so we have more control over the default AddrFilter from within the PkarrPublisherBuilder, and because we need it for pkarr, we keep this consistent across publishing services.

As a bonus, now pure resolvers don't suddently have a builder method for address filtering that cannot apply to them (but they can still be wrapped in FilteredAddressLookup, even though that's less discoverable).

Fixes #4009

Breaking Changes

  • behavioral: PkarrPublisher and DhtPublisher will now by default publish only the relay URL, instead of detecting if RelayMode::Disabled was set and in such cases publishing IP addresses. We recommend users to explicitly set .addr_mode(AddrFilter::unfiltered()) if they set relay_mode(RelayMode::Disabled), to re-enable publishing IP addresses publicly.

@matheus23 matheus23 self-assigned this Mar 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4012/docs/iroh/

Last updated: 2026-03-16T12:07:23Z

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026 •
edited
Loading

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 7dd75a1

@n0bot n0bot bot added this to iroh Mar 12, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Mar 12, 2026
@Frando Frando mentioned this pull request Mar 12, 2026
Merged
11 tasks
matheus23 pushed a commit that referenced this pull request Mar 12, 2026
@Frando
refactor: Remove FilteredBuilder and with_addr_filter (#4013)
fe0e6be 
## Description

Based on #4012 which is based on #4010

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist
<!-- Remove any that are not relevant. -->
- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
- [ ] List all breaking changes in the above "Breaking Changes" section.
- [ ] Open an issue or PR on any number0 repos that are affected by this
breaking change. Give guidance on how the updates should be handled or
do the actual updates themselves. The major ones are:
    - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc)
    - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip)
    - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs)
    - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe)
    - [ ] [`sendme`](https://github.com/n0-computer/sendme)
Base automatically changed from fix-ip-publish to main March 12, 2026 11:50
Frando
Frando reviewed Mar 12, 2026
View reviewed changes
matheus23 and others added 6 commits March 12, 2026 12:52
@matheus23
fix(iroh)!: Don't publish IP addresses from PkarrPublisher by default
8d4b5f1
@matheus23
Determine pkarr filter based on endpoint relay config
58b7f0e
@matheus23
Add FilteredAddressLookup::into_inner
cd33880
@matheus23
Don't set blanket address filters on the Preset level
12dadfa
@Frando @matheus23
refactor: Remove FilteredBuilder and with_addr_filter (#4013)
4bf263f 
## Description

Based on #4012 which is based on #4010

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist
<!-- Remove any that are not relevant. -->
- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
- [ ] List all breaking changes in the above "Breaking Changes" section.
- [ ] Open an issue or PR on any number0 repos that are affected by this
breaking change. Give guidance on how the updates should be handled or
do the actual updates themselves. The major ones are:
    - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc)
    - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip)
    - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs)
    - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe)
    - [ ] [`sendme`](https://github.com/n0-computer/sendme)
@matheus23
Don't try to auto-detect whether to use AddrFilter::relay_only or not
e2279ad 
`cargo make format`
@matheus23 matheus23 force-pushed the matheus23/fix-ip-publish branch from b9071fc to e2279ad Compare March 12, 2026 11:53
dignifiedquire
dignifiedquire reviewed Mar 12, 2026
View reviewed changes
@matheus23 matheus23 mentioned this pull request Mar 12, 2026
Merged
3 tasks
dignifiedquire
dignifiedquire approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@dignifiedquire
Copy link
Copy Markdown
Contributor

dignifiedquire commented Mar 16, 2026

the mdns example might need some updates

Frando
Frando reviewed Mar 16, 2026
View reviewed changes
Frando
Frando reviewed Mar 16, 2026
View reviewed changes
Frando
Frando reviewed Mar 16, 2026
View reviewed changes
@matheus23
Copy link
Copy Markdown
Member Author

matheus23 commented Mar 16, 2026

the mdns example might need some updates

Does it? It seems to be working fine for me.

@dignifiedquire
Copy link
Copy Markdown
Contributor

dignifiedquire commented Mar 16, 2026

the mdns example might need some updates

Does it? It seems to be working fine for me.

it does, but we don't need to remove filters anymore, we could keep using the preset now

@matheus23
Copy link
Copy Markdown
Member Author

matheus23 commented Mar 16, 2026

Updated the example. This should be ready.

@matheus23 matheus23 force-pushed the matheus23/fix-ip-publish branch from 7bd8dc1 to 23a54e8 Compare March 16, 2026 12:05
@matheus23 matheus23 enabled auto-merge March 16, 2026 12:06
@matheus23 matheus23 added this pull request to the merge queue Mar 16, 2026
@dignifiedquire dignifiedquire removed this pull request from the merge queue due to a manual request Mar 16, 2026
@dignifiedquire dignifiedquire added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit b3da940 Mar 16, 2026
29 of 30 checks passed
@github-project-automation github-project-automation bot moved this from 🚑 Needs Triage to ✅ Done in iroh Mar 16, 2026
@matheus23 matheus23 deleted the matheus23/fix-ip-publish branch March 16, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frando Frando Frando left review comments

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees

@matheus23 matheus23

Labels

None yet

Projects

iroh
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accidental publishing of IP addresses in DNS

3 participants

@matheus23 @dignifiedquire @Frando