refactor: do not use CancellationToken in public API#3947
Merged
Frando merged 1 commit intoramfox/dropped-endpointfrom Feb 16, 2026
Merged
refactor: do not use CancellationToken in public API#3947Frando merged 1 commit intoramfox/dropped-endpointfrom
Frando merged 1 commit intoramfox/dropped-endpointfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3947/docs/iroh/ Last updated: 2026-02-16T10:48:56Z |
matheus23
approved these changes
Feb 16, 2026
ramfox
pushed a commit
that referenced
this pull request
Feb 17, 2026
## Description Based on #3879 This makes `Endpoint::closed` return a named future instead of `CancellationToken` to not depend on `tokio_util` in our public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #3879
This makes
Endpoint::closedreturn a named future instead ofCancellationTokento not depend ontokio_utilin our public API.