refactor!: rename Node to Endpoint in all cases#3542
Merged
dignifiedquire merged 10 commits intomainfrom Oct 15, 2025
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3542/docs/iroh/ Last updated: 2025-10-15T13:08:27Z |
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
Frando
reviewed
Oct 15, 2025
|
|
||
| impl Ticket for NodeTicket { | ||
| impl Ticket for EndpointTicket { | ||
| const KIND: &'static str = "node"; |
Member
There was a problem hiding this comment.
s/node/endpoint? If we want to break all tickets.
Contributor
Author
There was a problem hiding this comment.
yeah, I wasn't sure about this one
Frando
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
| /// The [`NodeId`] of the original sender. | ||
| remote_node_id: NodeId, | ||
| /// The [`EndpointId`] of the original sender. | ||
| remote_endpoint_id: EndpointId, |
Contributor
There was a problem hiding this comment.
i have no idea if this is a wire-change or not
Contributor
Author
There was a problem hiding this comment.
asfaict it is not, thanks to the custom encoding
flub
reviewed
Oct 15, 2025
Frando
reviewed
Oct 15, 2025
Frando
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
Contributor
There was a problem hiding this comment.
should this file have been renamed?
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
reviewed
Oct 15, 2025
flub
approved these changes
Oct 15, 2025
Contributor
flub
left a comment
There was a problem hiding this comment.
if you get CI happy it's probably ok
11 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Description #3542 included unintended changes to the `RelayMap` API. This cleans this up: We don't call entries in the relay map *endpoints*, instead we simply call them *relays*. Also improves the API docs and adds some examples for how to work with the `FromIterator` generic types used in construction and access. And renamed a couple of variables at use site in tests mostly to follow the new pattern. ## Breaking Changes ### Renamed * `iroh_relay::RelayMap::get_endpoint` -> `get` * `iroh_relay::RelayMap::endpoints` -> `relays` * `iroh_relay::RelayMap::contains_endpoint` -> `contains` ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented. - [ ] List all breaking changes in the above "Breaking Changes" section. - [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are: - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc) - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip) - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs) - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe) - [ ] [`sendme`](https://github.com/n0-computer/sendme)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This normalizes naming, to call the main iroh handle,
Endpointand instead ofNodein all cases.Closes #3301
Breaking Changes
All APIs that include
Nodenow useEndpointrenamed
iroh_relay::RelayNode->RelayConfigiroh_base::NodeAddr->EndpointAddriroh_base::NodeAddr.node_id->endpoint_idiroh_base::NodeId->EndpointIdiroh_base::NodeTicket->EndpointTicketiroh::Endpoint::node_addr->iroh::Endpoint::addriroh::Endpoint::watch_node_addr->iroh::Endpoint::watchaddriroh::Endpoint::node_id->iroh::Endpoint::id