Conversation
We get very weird errors from nextest, I suspect this is a regression. This version is 3 months old, which is probably something nice to try. This does not yet do this everywhere, e.g. windows still installs the latest. But this is enough to see if it helps.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3088/docs/iroh/ Last updated: 2025-01-03T08:29:32Z |
Arqu
left a comment
There was a problem hiding this comment.
Do you have a link / example of the regression?
Every other flaky run in the last month results in FAILEXEC. I looked into the code of nextest and strongly suspect a regression there. If proven right it will be worth to at least report this, ideally figure out their bug (because I suspect this is not easy to reproduce). |
|
Ah ok, I wasn't sure which problem you were referring to. Yeah we need more info there. |
|
😭 And now let's copy this PR into all other repos 🥲 |
|
Wait are we happy with this solution, did it work? |
|
Hard to know for sure. But so far this solution hasn't failed (succeeded 3 times). |
## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> Nextest seems to have some issues with file descriptors in the latest version. This pins nextest to a 3 month old version so we get reliable flaky test runs again. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> Related PR: n0-computer/iroh#3088 ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - ~~[ ] All breaking changes documented.~~
Description
We get very weird errors from nextest, I suspect this is a regression.
This version is 3 months old, which is probably something nice to try.
This does not yet do this everywhere, e.g. windows still installs the
latest. But this is enough to see if it helps.
Breaking Changes
Notes & open questions
Change checklist