Move NDData I/O functions to astropy.io.fits.connect#1
Closed
astrofrog wants to merge 1 commit into
Closed
Conversation
4 tasks
mwcraig
pushed a commit
that referenced
this pull request
Jun 2, 2016
Finalizes attribute and frame naming conventions for AstrometricFrame and subclasses.
mwcraig
pushed a commit
that referenced
this pull request
Jun 9, 2017
fixes for test_wcs. Yields removed to get rid of deprecation warnings in pytest3 and be compatible with pytest4
mwcraig
pushed a commit
that referenced
this pull request
Jun 9, 2017
Remove unit checks that are irrelevant for the bug fix.
mwcraig
pushed a commit
that referenced
this pull request
Jun 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the following major changes:
astropy.io.fits.connectfor consistency with Table (and now split that intoconnect_tableandconnect_nddataIOMixinI think
NDDatashould actually inherit fromIOMixin(as done here) and as a bonus it makes everything a lot simpler for the mix-in class.If you agree, then merge, otherwise I think we should remove the I/O stuff from astropy#2905 for now.
Note that the I/O is undergoing a larger scale refactoring so this will change in future anyway, but for now this is the most consistent with what we do for
Table.