fix(cli): scope global params from env#2827
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 require-ready-label-and-ciWonderful, this rule succeeded.
|
Greptile SummaryThis PR promotes API-wide string scope parameters (e.g.
Confidence Score: 5/5Safe to merge. The flatGlobal/trueGlobal boundary is preserved correctly and is now explicitly tested by an embedded helper test. The key concern from the prior review thread — that env-backed scope defaults might land in trueGlobal and silently break dependent-request calls on Asana-style APIs — is demonstrably addressed: setGlobalDefault writes into flatGlobal, and the new TestSyncGlobalScopeEnvDefaultsUseFlatGlobal helper test verifies that dependent requests do not receive the scope param from env defaults. The parser change widening the counting phase to include required params is intentional and covered by the updated tests. No credential-path reads are introduced. No files require special attention. Important Files Changed
|
Merge Queue Status
This pull request spent 22 minutes 12 seconds in the queue, including 21 minutes 54 seconds running CI. Required conditions to merge
|
Summary
Closes #2389
Verification