fix(cli): stamp printed MCP versions in bundles by tmchow · Pull Request #2817 · mvanhorn/cli-printing-press

tmchow · 2026-06-07T19:01:19Z

Intent

Issue: Closes #2387

Printed CLI MCPB bundles no longer present the Printing Press generator release as the bundle's own version, and generated MCP servers no longer default to a release-looking 1.0.0 serverInfo version before release stamping.

Approach

Generate-time manifest.json now uses a neutral 0.0.0 placeholder because the printed CLI release tag is not known during generation. The bundle path accepts --version and stamps that printed CLI release version into the manifest bytes inside the .mcpb archive without mutating the on-disk manifest.

Generated HTTP and device MCP server mains now default their ldflag-overridable version variable to 0.0.0-dev; the existing goreleaser -X main.version={{ .Version }} injection remains the release-time source of truth.

Scope

Primary area: MCPB packaging and generated MCP server version metadata.

Why this belongs in this repo: the bug appears in every future printed CLI generated or bundled by the Printing Press, so the fix belongs in the generator and bundle command rather than in one published CLI.

Catalog Justification

Embedded catalog fit: N/A

Distinct blueprint pattern: N/A

Closest existing entries checked: N/A

Source provenance: N/A

Auth and tenant assumptions: N/A

Safe default surface: N/A

Generation path: N/A

Stale-body check: N/A

Risk

The main risk is release workflow adoption: published CLI workflows must pass cli-printing-press bundle --version <release> to stamp non-placeholder MCPB versions. Generated MCP server releases still receive the tag via existing goreleaser ldflags, and generate-time artifacts intentionally remain placeholders.

Output Contract

Generated MCP server main.go files now emit var version = "0.0.0-dev" and still pass that variable to server.NewMCPServer. Golden fixtures cover HTTP, stdio, and device generated MCP mains. scripts/verify-generator-output.sh compiled representative generated modules for HTTP, device, and MCP-first cases.

Verification

Generator/template change: verified generated output, including emitted-code assertions or compiled generated CLI output
Generator/template change: covered the affected fallback or variant shape, not only happy-path fixtures
Generator/template change: checked emitted definitions and call sites for matching gates
go test ./internal/pipeline ./internal/cli ./internal/generator -run 'Test(BuildMCPBBundle|WriteMCPBManifest|NewBundleCmd|GenerateMCPMainRemoteOptIn|GeneratedBLEDeviceEmitsMCPSurface)'
scripts/golden.sh verify
scripts/verify-generator-output.sh generate-golden-api generate-device-ble generate-mcp-api
go test ./...
go build -o ./cli-printing-press ./cmd/cli-printing-press
golangci-lint run ./...
Headless read-only review: no findings

AI / Automation Disclosure

No AI or automation was used
Human-reviewed: AI or automation was used, and a human reviewed the work for intent, fit, and obvious issues before submission
AI-reviewed only: an AI agent reviewed the work, but no human reviewed it before submission
Fully automated: generated and submitted without human review for this specific change

mergify · 2026-06-07T19:01:55Z

greptile-apps · 2026-06-07T19:05:08Z

Greptile Summary

This PR fixes MCPB bundle versioning by decoupling the generate-time manifest from the release tag: manifest.json now emits a 0.0.0 placeholder, and the new --version flag on cli-printing-press bundle stamps the real release version into the ZIP's manifest bytes without touching the on-disk file. Generated MCP server mains also drop the misleading 1.0.0 default in favour of 0.0.0-dev, keeping goreleaser ldflags as the authoritative injection point.

Version stamping: BuildMCPBBundle accepts a Version field in BundleParams and uses rewriteMCPBManifestVersion (a map[string]any round-trip) to patch the version inside the ZIP only, preserving all custom manifest fields and leaving the on-disk manifest.json byte-for-byte unchanged.
Semver validation: validateBundleVersion enforces v-prefix rejection and semver shape at the CLI layer using both a custom regex and golang.org/x/mod/semver.IsValid; invalid inputs exit with ExitInputError and a clear message.
Golden fixtures & tests: All four golden main.go files updated; new tests cover version stamping, on-disk immutability, and rejection of malformed version strings.

Confidence Score: 5/5

Safe to merge; the change is well-scoped and the on-disk manifest is never mutated by the version-stamp path.

The core logic — stamping the version into ZIP bytes while leaving the on-disk manifest unchanged — is straightforward and thoroughly tested. Both the --version validation and the manifest rewrite have dedicated subtests covering happy paths, immutability of on-disk files, and rejection of invalid inputs. Golden fixture updates and compiled-output verification are included. The one style note (dead manifest.Version assignment) has no runtime impact.

No files require special attention.

Important Files Changed

Filename	Overview
internal/pipeline/mcpb_bundle.go	Adds Version to BundleParams and rewriteMCPBManifestVersion to stamp version into ZIP bytes without mutating the on-disk manifest; dead manifest.Version struct assignment noted.
internal/pipeline/mcpb_manifest.go	Removes PrintingPressVersion/version.Version fallbacks from bundleVersion; now always returns "0.0.0" placeholder; bundleVersion() parameter removed cleanly.
internal/cli/bundle.go	Adds --version flag with validateBundleVersion enforcing v-prefix rejection and semver shape; passes Version through to BundleParams; well-tested.
internal/generator/templates/main_mcp.go.tmpl	Changes generated MCP server default version from "1.0.0" to "0.0.0-dev" so goreleaser ldflags injection is the sole release-time source of truth.
internal/cli/bundle_test.go	Adds tests verifying version stamp propagates into ZIP but not on-disk manifest, and that invalid version strings are rejected with clear error messages.
internal/pipeline/mcpb_bundle_test.go	New subtest confirms version stamping preserves custom top-level and nested JSON fields while leaving the on-disk manifest byte-for-byte unchanged.

Sequence Diagram

sequenceDiagram
    participant CI as Release CI
    participant CLI as cli-printing-press bundle
    participant BV as validateBundleVersion
    participant BB as BuildMCPBBundle
    participant Disk as manifest.json (disk)
    participant ZIP as .mcpb ZIP

    CI->>CLI: "bundle <dir> --version 1.2.3"
    CLI->>BV: validateBundleVersion("1.2.3")
    BV-->>CLI: ok
    CLI->>Disk: ReadFile manifest.json (version: "0.0.0")
    CLI->>BB: "BundleParams{Version: "1.2.3"}"
    BB->>BB: rewriteMCPBManifestVersion(bytes, "1.2.3")
    BB->>ZIP: write manifest with version "1.2.3"
    BB->>ZIP: write MCP binary
    Disk-->>Disk: unchanged ("0.0.0")
    BB-->>CLI: nil
    CLI-->>CI: wrote demo.mcpb

_{Reviews (3): Last reviewed commit: "fix(cli): use cutprefix for bundle versi..." | Re-trigger Greptile}

tmchow · 2026-06-07T22:35:18Z

@Mergifyio queue

mergify · 2026-06-07T23:17:47Z

fix(cli): stamp printed MCP versions in bundles

4b8a2da

greptile-apps Bot reviewed Jun 7, 2026

View reviewed changes

Comment thread internal/pipeline/mcpb_manifest.go

Comment thread internal/cli/bundle.go

fix(cli): validate bundle release versions

baafb79

tmchow added the ready-to-merge Allow Mergify to queue and merge this PR when protections pass label Jun 7, 2026

tmchow added 2 commits June 7, 2026 15:38

fix(cli): clarify bundle version errors

74fe0cb

fix(cli): use cutprefix for bundle versions

3caf901

mergify Bot added the queued PR is in the Mergify merge queue label Jun 7, 2026

mergify Bot added a commit that referenced this pull request Jun 7, 2026

Merge of #2817

4bc1c94

mergify Bot mentioned this pull request Jun 7, 2026

merge queue: embarking main (88617bb), #2818, #2819 and #2817 together #2848

Closed

94 tasks

mergify Bot added a commit that referenced this pull request Jun 7, 2026

Merge of #2817

f6d8273

mergify Bot mentioned this pull request Jun 7, 2026

merge queue: embarking main (d0a5d24) and #2817 together #2849

Closed

94 tasks

mergify Bot added a commit that referenced this pull request Jun 7, 2026

Merge of #2817

e3b5d70

mergify Bot added a commit that referenced this pull request Jun 7, 2026

Merge of #2817

def4ade

mergify Bot merged commit e4bc665 into main Jun 7, 2026
30 checks passed

mergify Bot deleted the fix/issue-2387-mcp-versions branch June 7, 2026 23:17

mergify Bot removed the queued PR is in the Mergify merge queue label Jun 7, 2026

mvanhorn mentioned this pull request Jun 7, 2026

chore(main): release 4.23.1 #2821

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): stamp printed MCP versions in bundles#2817

fix(cli): stamp printed MCP versions in bundles#2817
mergify[bot] merged 4 commits into
mainfrom
fix/issue-2387-mcp-versions

tmchow commented Jun 7, 2026

Uh oh!

mergify Bot commented Jun 7, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jun 7, 2026 •

edited

Loading

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

tmchow commented Jun 7, 2026

Uh oh!

Uh oh!

mergify Bot commented Jun 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

tmchow commented Jun 7, 2026

Intent

Approach

Scope

Catalog Justification

Risk

Output Contract

Verification

AI / Automation Disclosure

Uh oh!

mergify Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 require-ready-label-and-ci

Uh oh!

greptile-apps Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

tmchow commented Jun 7, 2026

Uh oh!

Uh oh!

mergify Bot commented Jun 7, 2026

Merge Queue Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mergify Bot commented Jun 7, 2026 •

edited

Loading

greptile-apps Bot commented Jun 7, 2026 •

edited

Loading