Conversation
2 tasks
raulk
approved these changes
Aug 7, 2019
bigs
approved these changes
Aug 10, 2019
lidel
approved these changes
Aug 12, 2019
Member
There was a problem hiding this comment.
I am +1 for explicit /tls/http, however /https is already used in the wild and we need to support both.
cc multiformats/multiaddr#63 (Defining /http)
This was referenced Aug 12, 2019
Member
|
While we are at it, would be good to quickly decide what should be the canonical multiaddr representation of HTTPS, and ensure it is the default in the libraries we use internally for converting URLs to multiaddrs. Please post feedback in:
|
ntninja
added a commit
to ntninja/multiaddr
that referenced
this pull request
Aug 24, 2020
ntninja
added a commit
to ntninja/py-multiaddr
that referenced
this pull request
Aug 24, 2020
Stebalien
added a commit
to multiformats/multiaddr
that referenced
this pull request
Jun 30, 2021
Add TLS as per GH/multiformats/multicodec#145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternatively, we could repurpose https (443) as TLS and define HTTPS to be
/tls/http(which is, IMO, more correct).But let's make this decision quickly. I'm fine keeping this as it is and later deprecating
/httpsin favor of/tls/http.