Conversation
|
2022-01-07: we're interested in including this because it shows we truly can support base 256 (and it's fun). I left some comments on characters that aren't visible on macOS 12.0.1. @rvagg : not a high priority at all, but do you have any concerns with this getting merged? |
|
This is fine by me, but it'd be good to get multiformats/multibase#88 sorted first, which Steven had some comments on re validity - which maybe should be coupled with the feedback here about FF availability - ensure we get the proper set included. Once we get it sorted maybe I'll try and put a version in js-multiformats too for fun. |
|
Updated to the new charset which includes comments made. |
The spec submodule was on a 2 year old commit and the tests structure changed, this bring it to the latest master at this time.
|
Note, in case multiformats/multibase#88 isn't merged with |
924eccc to
202fdc2
Compare
This include fixes for UTF-8 as well as base256emoji encoding (an encoding which actually use UTF-8).
willscott
left a comment
There was a problem hiding this comment.
Use of utf8 methods looks reasonable
|
thanks for the input Will |
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
This add supports for base256emoji. multiformats/go-multibase#46
Related: multiformats/multibase#88 (note it's not actually blocking because my last commit already update to the commit on my branch).
This include fixes for UTF-8 as well as base256emoji encoding (an encoding which actually use UTF-8).
If you want to know why I think this should be merged, see multiformats/multibase#88. :)