Remove stale commented-out foot collision geoms from G1 XML#970
Merged
Conversation
The old 3-geom foot collision geometry was replaced with the current multi-geom version but the original geoms were left behind as comments. The first geom in each commented block was identical to the active one, and the rest were superseded. Remove both left and right foot commented blocks.
erikfrey
added a commit
to erikfrey/mujoco_warp
that referenced
this pull request
May 4, 2026
erikfrey
added a commit
to google-deepmind/mujoco_warp
that referenced
this pull request
May 4, 2026
…#1325) * Consolidate aloha benchmarks into single directory Merge aloha_pot, aloha_sdf, aloha_cloth into benchmarks/aloha/ with scene-specific XMLs (scene_pot.xml, scene_sdf.xml, scene_cloth.xml). Add aloha_clutter benchmark with YCB/GSO object assets from aloha_sim. Other changes: - Add glob pattern support in run.py asset specs for flexible asset mapping - Migrate run.py from os.path to pathlib - Auto-set nstep from replay trajectory length when not explicitly specified - Update benchmarks/README.md documentation - Generalize load_trajectory docstring and variable naming * Address PR comments. * Address PR comments. * Address PR comments. * Update XML after mujocolab/mjlab#970
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The G1 XML had commented-out foot collision geoms for both left and right feet that were superseded when the foot collision geometry was updated to use more capsules. The first geom in each commented block was identical to the active one, and the remaining two had different values. Removing the dead comments to reduce clutter.