[useIsFocusVisible] Remove focus-visible if focus is re-targetted#22102
Merged
[useIsFocusVisible] Remove focus-visible if focus is re-targetted#22102
Conversation
Member
Author
|
Argos failure makes sense. It displayed all items as focus-visible but not it only displayes the last one as focus-visible. I'm pushing a visual change that will create a diff regardless of this bug fix. The diff due to this bug fix is visible in https://www.argos-ci.com/mui-org/material-ui/builds/2968 Though this test revealed another bug that I'll try to fix. It's less |
90c51fd to
6a4ca14
Compare
oliviertassinari
approved these changes
Aug 8, 2020
2 tasks
42 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Observed this bug a couple of times but wasn't able to understand/reproduce it. Saw it again in #22062 but this time reproducible:
the focus marker is still focus-visible but focus is on the the focus trap. Only every second click removes the focus-visible style:
Added a test that mimics TrapFocus to prevent future regression.