[TrapFocus] Add documentation#22062
Merged
oliviertassinari merged 6 commits intomui:nextfrom Aug 8, 2020
Merged
Conversation
4a42889 to
ca12063
Compare
1 task
joshwooding
reviewed
Aug 4, 2020
ca12063 to
2d6c06a
Compare
2d6c06a to
070deb1
Compare
mbrookes
previously requested changes
Aug 6, 2020
Co-authored-by: Matt <github@nospam.33m.co>
eps1lon
previously requested changes
Aug 6, 2020
Member
eps1lon
left a comment
There was a problem hiding this comment.
The page should have a big warning that this component is experimental.
mbrookes
reviewed
Aug 6, 2020
Co-authored-by: Matt <github@nospam.33m.co>
mbrookes
approved these changes
Aug 6, 2020
joshwooding
approved these changes
Aug 6, 2020
eps1lon
previously requested changes
Aug 7, 2020
thanks for the review, I have updated the changes to take them into account
eps1lon
approved these changes
Aug 7, 2020
Member
eps1lon
left a comment
There was a problem hiding this comment.
Looks good. Already found a bug with existing components 😄
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-22062--material-ui.netlify.app/components/trap-focus/
Add docs to help with #21857
Benchmarked with