Conversation
|
FYI - this doesn't include value/valueLink support yet... I'm going to do this shortly. |
|
I've added value/valueLink support. Note that |
947ad74 to
3ad3ae9
Compare
|
@chrismcv On the docs page, the Custom Child input is behaving a little strange. looks like you have it on a disabled input, but it's still clickable slightly above the hint text. Also, what is the difference between SelectField and DropdownMenu? As a user, would I just opt to use SelectField all the time? Thank you so much for this! |
|
Sorry about that... carelessness! Should be sorted now.... DropdownMenu is for use when embedding it in Toolbars etc - as the height styling is fairly different. Select Field should be preferred for any "form" type usage. Also - the changes to menu apply keyboard friendliness to Menu/NestedMenu/Left Nav as well (assuming they have focus)... I didn't make LeftNav focusable by default, but this might be worth considering as well. Finally - I patched up jshint.js and package.json to fix #845, which has been causing my grief as well. |
|
Found a display glitch on the last SelectField example. To recreate:
Also, SelectField with a default value does not highlight the menu item on first open. Could you also squash these commits down to 1 please? Thanks! |
ef5c34e to
e96d313
Compare
|
Should be everything now :) |
e96d313 to
961dd26
Compare
|
@chrismcv Were you able to recreate the problems I mentioned earlier? - #846 (comment) I'm still seeing it on my end. |
|
just checking now, thought i'd sorted last night... |
|
must have missed it when i squashed.... new commit there now... |
961dd26 to
850170e
Compare
|
Thanks @chrismcv ! |
* Update to the @date-io v1 * Fix luxon & moment issues * Update to date-io v1.0.1

This PR should sort #51.
It also includes #789 (which I'm using for "Select-Field".