Skip to content

[Select] First implementation#8023

Merged
oliviertassinari merged 1 commit intomui:v1-betafrom
oliviertassinari:next-select-field
Sep 6, 2017
Merged

[Select] First implementation#8023
oliviertassinari merged 1 commit intomui:v1-betafrom
oliviertassinari:next-select-field

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 3, 2017

A big thanks to @kybarg 🎉

  • Native version
  • Menu version
  • Accessibility
  • Finalize the API
  • Flow
  • Documentation
  • Edge cases
  • Unit tests
  • TypeScript

Also closes DropDownMenu issues as was used in the same context than the SelectField on the v0.x versions:


  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added v1 scope: select Changes related to the select. labels Sep 3, 2017
@oliviertassinari
Copy link
Member Author

@sebald I might not have the energy of going into the TypeScript coverage to begging with. I'm going to handle the unit tests now.

@sebald
Copy link
Contributor

sebald commented Sep 6, 2017

@oliviertassinari sure. Do you want the typings to be part of the PR or should we create them after this is merged?

@oliviertassinari
Copy link
Member Author

@sebald I will try to write some, but I don't guarantee the outcome 😆 . So I would love to have you giving a second look.

@sebald
Copy link
Contributor

sebald commented Sep 6, 2017

Will do 😄

@oliviertassinari
Copy link
Member Author

@sebald Well, the yarn test:typescript command is outputting some errors 😬 . I'm not good at it.

@oliviertassinari oliviertassinari merged commit 50261b9 into mui:v1-beta Sep 6, 2017
@oliviertassinari oliviertassinari deleted the next-select-field branch September 6, 2017 21:47
@oliviertassinari oliviertassinari changed the title [SelectField] First implementation [Select] First implementation Sep 6, 2017
@oliviertassinari
Copy link
Member Author

@kybarg Thanks a lot for your original migration. It was a great help for this implementation! I have been taking advantage of some of your logic and some of your unit tests.

@ctavan
Copy link
Contributor

ctavan commented Sep 7, 2017

Wow, this is awesome and impressive! I feel that a 🎉 reaction on the PR comment is not enough to express my gratefulness 😄 !

@wieseljonas
Copy link
Contributor

@oliviertassinari @kybarg thank you for the great work

@tfuqua
Copy link
Contributor

tfuqua commented Sep 7, 2017

@oliviertassinari @kybarg awesome!

@nareshbhatia
Copy link
Contributor

@kybarg @oliviertassinari - you guys just made my day! Heartfelt Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: select Changes related to the select.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants