[Autocomplete] Type multiple values with readonly arrays.#38253
Merged
michaldudak merged 1 commit intomui:masterfrom Sep 4, 2023
Merged
[Autocomplete] Type multiple values with readonly arrays.#38253michaldudak merged 1 commit intomui:masterfrom
michaldudak merged 1 commit intomui:masterfrom
Conversation
Netlify deploy previewhttps://deploy-preview-38253--material-ui.netlify.app/ Bundle size report |
There is no reason to mutate the array once passed as a prop or when sending it to onChange.
5e16c69 to
4fca0c0
Compare
michaldudak
approved these changes
Aug 29, 2023
Member
michaldudak
left a comment
There was a problem hiding this comment.
👍 We don't intend to mutate props, so the change you're proposing looks ok.
Contributor
Author
|
Thanks @michaldudak , what's the next step to get this merged? |
Member
|
Nothing else is needed from your side. We'll include it in the release this week. |
2 tasks
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
pcorpet
added a commit
to pcorpet/material-ui
that referenced
this pull request
Nov 3, 2023
There is no reason to mutate the array once passed as a prop or when sending it to onChange. This is a second attempt of mui#38253, but not affecting Material UI package. See #39727 for context.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reason to mutate the array once passed as a prop or when sending it to onChange.