Skip to content

[website] Add about page#27599

Merged
siriwatknp merged 190 commits intomui:nextfrom
siriwatknp:rebranding/about
Aug 11, 2021
Merged

[website] Add about page#27599
siriwatknp merged 190 commits intomui:nextfrom
siriwatknp:rebranding/about

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 4, 2021

Preview: https://deploy-preview-27599--material-ui.netlify.app/branding/about/

waiting for #27598

  • added tooltip to show location on hover. I think it is nice to see the location apart from country flag.

    Screen Shot 2564-08-05 at 20 25 26

Lighthouse on desktop
Screen Shot 2564-08-09 at 12 52 22

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 9, 2021

@siriwatknp Oops, I was initially aiming to remove the duplication (x3 sx={{ height: '100%' }}).

@siriwatknp
Copy link
Member Author

@siriwatknp Oops, I was initially aiming to remove the duplication (x3 sx={{ height: '100%' }}).

Okay, no prob. I have brought it back. I don't think there is anything left for this page (checked the lighthouse in the PR description, it looks good to me)

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 9, 2021

  1. When the font loads, the layout shifts, it's distracting. OS font: ✅ Fixed

Capture d’écran 2021-08-10 à 00 42 52

Font loaded:

Capture d’écran 2021-08-10 à 00 42 55

In https://next.material-ui.com/branding/about/, we fixed it by forcing the line break where we want it (with a <br>)

  1. Here are no h1 on the page, this one should have it. (Found with Wave Chrome extension) ✅ Fixed

Capture d’écran 2021-08-10 à 00 45 48

  1. The img are used as links, you can add an alt, it's not decorative ✅ Fixed by using Icon instead

Capture d’écran 2021-08-10 à 00 48 11

  1. I think that we could challenge the UI/UX of the button.

Capture d’écran 2021-08-10 à 00 48 53

For instance, should it have the ripple when focused or an outlined as in https://next.material-ui.com/branding/about/

Capture d’écran 2021-08-10 à 00 49 35

  1. Something is off with the companies in dark mode

Capture d’écran 2021-08-10 à 00 52 01

@siriwatknp
Copy link
Member Author

@oliviertassinari For 4 and 5, I am waiting to hear from @danilo-leal opinion but I don't think it is a priority and can be improved later.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I'm holding on the reviews so we can get a first iteration in :)

@siriwatknp siriwatknp marked this pull request as ready for review August 10, 2021 09:33
@danilo-leal
Copy link
Collaborator

@oliviertassinari For 4 and 5, I am waiting to hear from @danilo-leal opinion but I don't think it is a priority and can be improved later.

About 4, what would you make it different? And about 5, we're going to revisit that in a refinement phase (updating the companies we use + the coloring and sizing of the logo - to all pages). Agree with not being a priority :) Very awesome work!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 11, 2021
@siriwatknp siriwatknp merged commit 7cbbad2 into mui:next Aug 11, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 12, 2021

I'm consolidating a list of feedback that we could handle for the polish phase:

  • Should the current page be highlighted?

Capture d’écran 2021-08-12 à 16 25 50

Capture d’écran 2021-08-12 à 16 27 23

  • In the title "About Us - Material-UI" => "About Us - MUI"?

@michaldudak
Copy link
Member

michaldudak commented Aug 12, 2021

What do you think about aligning the text baseline of companies' logos? I know it would require manual tweaks in each case, but IMO could look good.
logos

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 12, 2021

I recall @mbrookes did it for the current logos on the homepage, it felt better.

@mbrookes
Copy link
Member

mbrookes commented Aug 13, 2021

I'm not sure what the illustration resonates with

Decorating the logo also goes against the visual identity guidelines (ours, and in general). @danilo-leal let me know if you don't have them.

This was referenced Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants