Skip to content

[website] Add pricing page#27598

Merged
siriwatknp merged 193 commits intomui:nextfrom
siriwatknp:rebranding/pricing
Aug 11, 2021
Merged

[website] Add pricing page#27598
siriwatknp merged 193 commits intomui:nextfrom
siriwatknp:rebranding/pricing

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 4, 2021

@oliviertassinari
Copy link
Member

I have spent 1 hour on this PR, you can review the commits I have pushed. I have tried to polish stuff up. It looks great.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 9, 2021

  1. The page should have an h1, maybe this one? ✅ Fixed

Capture d’écran 2021-08-10 à 00 56 54

  1. I'm not sure if h3 is correct at this level ✅ Change to div instead

Capture d’écran 2021-08-10 à 00 56 47

  1. "Material-UI X" should become "MUI X" in the copywriting? ✅ Fixed
  2. Outdated wording? ✅ Fixed

Capture d’écran 2021-08-10 à 01 00 59

  1. The different prices not on the same horizontal line feels weird ✅ Fixed

lines

  1. ? ✅ Fixed
-The community edition let's you get going right away. Switch to MUI Advanced X to get more components & premium support.
+The community edition lets you get going right away. Switch to MUI X to get more components & premium support.
  1. I think that there is a "weight" issue with the yes/no checkmarks in the pricing table. This is the current version:

Capture d’écran 2021-08-10 à 01 09 51

Can you easily figure out where is what? I personally feel that the yes/no icons should be unbalanced, with different levels of luminance.

Add an opacity: 0.7 on the no icon, isn't it clearer?

Capture d’écran 2021-08-10 à 01 10 25

It might need even more. opacity: 0.5 feels even clearer (IMHO)

Capture d’écran 2021-08-10 à 01 14 10

@siriwatknp
Copy link
Member Author

@oliviertassinari

  1. I think that there is a "weight" issue with the yes/no checkmarks in the pricing table. This is the current version:

I think check should be a little bit bigger?

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 10, 2021

@siriwatknp it seems common (in other popular products) to leave the no cells blank, with no no-icon. I didn't experiment with the size, maybe it helps.

Capture d’écran 2021-08-10 à 14 42 56

Capture d’écran 2021-08-10 à 14 43 28

@siriwatknp
Copy link
Member Author

@danilo-leal any thought? otherwise, we can merge this as a first iteration and do the improvement again (there are some code that I need for the homepage improvement).

@danilo-leal
Copy link
Collaborator

danilo-leal commented Aug 10, 2021

@danilo-leal any thought? otherwise, we can merge this as a first iteration and do the improvement again (there are some code that I need for the homepage improvement).

I think what we can do is darken a little bit the check blue and make the X a little lighter (had received other feedback saying that the first iteration of the X icon seemed like it was disabled. Which, to me, wasn't so much of a big deal since it is, after all, not interactive. But...)

Edit: tried to do that in my latest commit. Let me know what you think.

@danilo-leal
Copy link
Collaborator

danilo-leal commented Aug 10, 2021

It's looking amazing! Very nice work, Jun! 😍
I have just two pieces of feedback:

  1. About the Data Grid row: are we going to add the icons there? And it's a bit weird to me that only this row is missing the recommended column background.

Screen Shot 2021-08-10 at 09 57 12

  1. I think we should standardize the inline link styles, we have two different ones going in this page: one on the Data Grid features and another on the FAQ box there. I personally would prefer we use the first.

Screen Shot 2021-08-10 at 10 00 17

Both are not a priority though. We can tackle it in a refinement phase.

@siriwatknp
Copy link
Member Author

  1. About the Data Grid row: are we going to add the icons there? And it's a bit weird to me that only this row is missing the recommended column background.

Added highlighted background but I think leaving the cell blank makes it different from usual cell which is better because it has interaction.

  1. I think we should standardize the inline link styles, we have two different ones going in this page: one on the Data Grid features and another on the FAQ box there. I personally would prefer we use the first.

I changed the weight of the links to 500, I think it looks better (not too bold but still obvious among normal text).

@siriwatknp siriwatknp merged commit c035c97 into mui:next Aug 11, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 12, 2021

I'm consolidating a list of feedback that we could handle for the polish phase:

  • In dark mode, the icons look broken

Capture d’écran 2021-08-12 à 15 53 19

  • In dark mode, are we should about the tab selection UI state?

Capture d’écran 2021-08-12 à 15 53 51

  • The "no" icons look too balanced in retrospect to the "yes" icons.

Capture d’écran 2021-08-12 à 15 54 24

The Figma asset was updated to leverage imbalance, it works better

Capture d’écran 2021-08-12 à 15 56 09

  • In the "How many licenses do I need?" FAQ, we use "Material-UI X" over MUI X".
  • There is something weird on smaller screens

Capture d’écran 2021-08-12 à 15 58 09

  • We should kill the legacy page
  • We might want to try with a lighter "flash" background color:

Capture d’écran 2021-08-12 à 16 02 40

  • We probably miss an aria-label on this button

Capture d’écran 2021-08-12 à 16 00 26

  • Maybe we need to reconsider this illustration. I personally fail to get the link with the message

Capture d’écran 2021-08-12 à 16 04 46

  • What should we do for the social card?

Capture d’écran 2021-08-12 à 16 06 10

https://cards-dev.twitter.com/validator

  • Should we leverage h3? I have tried to search on Google about SEO impacts, I couldn't find clear information. The places where it might make sense:

Capture d’écran 2021-08-12 à 16 14 13

Capture d’écran 2021-08-12 à 16 14 03

  • In the title "Pricing - Material-UI" => "Pricing - MUI"?

This was referenced Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants