Conversation
|
I have spent 1 hour on this PR, you can review the commits I have pushed. I have tried to polish stuff up. It looks great. |
-The community edition let's you get going right away. Switch to MUI Advanced X to get more components & premium support.
+The community edition lets you get going right away. Switch to MUI X to get more components & premium support.
Can you easily figure out where is what? I personally feel that the yes/no icons should be unbalanced, with different levels of luminance. Add an It might need even more. |
I think check should be a little bit bigger? |
0ce40d9 to
b0fe55a
Compare
|
@siriwatknp it seems common (in other popular products) to leave the no cells blank, with no no-icon. I didn't experiment with the size, maybe it helps. |
|
@danilo-leal any thought? otherwise, we can merge this as a first iteration and do the improvement again (there are some code that I need for the homepage improvement). |
I think what we can do is darken a little bit the check blue and make the X a little lighter (had received other feedback saying that the first iteration of the X icon seemed like it was disabled. Which, to me, wasn't so much of a big deal since it is, after all, not interactive. But...) Edit: tried to do that in my latest commit. Let me know what you think. |
|
It's looking amazing! Very nice work, Jun! 😍
Both are not a priority though. We can tackle it in a refinement phase. |
Added highlighted background but I think leaving the cell blank makes it different from usual cell which is better because it has interaction.
I changed the weight of the links to |
|
I'm consolidating a list of feedback that we could handle for the polish phase:
The Figma asset was updated to leverage imbalance, it works better
https://cards-dev.twitter.com/validator
|






















Preview: https://deploy-preview-27598--material-ui.netlify.app/branding/pricing/
What's left
What should be the link for "Get Started"use same links as previous rebranding.