[theme] Rename `createMuiTheme` to `createTheme` by m4theushw · Pull Request #25992 · mui/material-ui

m4theushw · 2021-04-26T20:49:09Z

Depreciations

[theme] Rename createMuiTheme to createTheme.
Developers only need one theme in their application. A prefix would suggest a second theme is needed. It's not the case. createMuiTheme will be removed in v6.

-import { createMuiTheme } from '@material-ui/core/styles';
+import { createTheme } from '@material-ui/core/styles';

-const theme = createMuiTheme({
+const theme = createTheme({

I have followed (at least) the PR section of the contributing guide.

Part of #20012.

Sorry for the huge PR. 😅 I did a search & replace for createMuiTheme ignoring everything from the blog, CHANGELOG and migration guides of previous versions. I didn't rename variables names: muiTheme -> theme.

Should we rename unstable_createMuiStrictModeTheme?

mui-pr-bot · 2021-04-26T20:51:03Z

Details of bundle changes

Generated by 🚫 dangerJS against 5a44e9a

oliviertassinari · 2021-04-26T22:00:58Z

Should we rename unstable_createMuiStrictModeTheme?

This is for v4. I believe it's no longer relevant anymore cc @eps1lon. It looks like another breaking change we should do.

eps1lon · 2021-04-27T11:21:54Z

This is for v4. I believe it's no longer relevant anymore cc @eps1lon. It looks like another breaking change we should do.

Let's keep it for now since there are more StrictMode changes coming in React core. We can make it a no-op though or rather just an alias for createMuiTheme i.e. keep the interface but simplify the implementation.

oliviertassinari · 2021-04-27T18:49:47Z

Let's keep it for now since there are more StrictMode changes coming in React core. We can make it a no-op though or rather just an alias for createMuiTheme i.e. keep the interface but simplify the implementation.

Actually, should we do the same with createMuiTheme()? I mean, do we really need to make this a BC in v5? It seems to impact a lot of people, the overhead for us to only remove it in v6 seems acceptable. Maybe we could do #26004 on v5 as well. It's more or less what we did for MuiThemeProvider -> ThemeProvider. We took a lot of time to make it happen. Thoughts?

m4theushw · 2021-04-27T22:30:24Z

Actually, should we do the same with createMuiTheme()? I mean, do we really need to make this a BC in v5? It seems to impact a lot of people, the overhead for us to only remove it in v6 seems acceptable. Maybe we could do #26004 on v5 as well. It's more or less what we did for MuiThemeProvider -> ThemeProvider. We took a lot of time to make it happen. Thoughts?

I would rename it, but keeping createMuiTheme with a warning to use the new recommendation. This breaking change doesn't bring value for users and we already have other more important changes in v5 that will require attention.

mnajdova · 2021-04-28T15:24:31Z

docs/src/pages/components/about-the-lab/about-the-lab-zh.md

 ```tsx
 import '@material-ui/lab/themeAugmentation';

-const theme = createMuiTheme({


I don't think we are supposed to do changes to the translated files. @oliviertassinari ?

It's best to avoid it as it add noises in the pull requests. But since this one is already very noisy, no strong preferences.

mnajdova · 2021-04-28T15:30:01Z

packages/material-ui/test/umd/run.js

@@ -47,7 +47,7 @@ async function createApp() {

  let index = await fse.readFile(path.join(rootPath, 'examples/cdn/index.html'), 'utf8');
  index = index.replace(
-    'https://unpkg.com/@material-ui/core@latest/umd/material-ui.development.js',
+    'https://unpkg.com/@material-ui/core@next/umd/material-ui.development.js',


how is this related?

The replace was doing nothing, because the path in examples/cdn/index.html uses the next tag. Since I had removed createMuiTheme it broke the e2e tests. Now that we have createMuiTheme back it could be reverted, or we leave it but once v5 becomes stable we have to update it back to latest.

https://github.com/mui-org/material-ui/blob/d7c0ae5958a274c6d7043b3bda8291a1d93fd3c1/examples/cdn/index.html#L9

Got it, thanks! Let’s leave it I’d say

I would personally keep latest so we don't forget to update it.

On this CDN aspect, I was also eager to replace/complement this example with something more modern https://trello.com/c/8QGmlDLH

mnajdova

I've scanned all files, this is the only non related change I could spot - #25992 (comment) I am going to create lots of conflicts with the PRs that removes the @material-ui/styles utils from core, so I'd say it's better if we can merge this soon :)

This reverts commit 1d69eb5.

mnajdova · 2021-04-29T07:22:59Z

I am merging this one, not keep on resolving merge conflicts in 100+ files :D

* migrate to emotion * make styleProps optional * remove lint and add fn name * use yearButton from styles * revert types * [docs] Document all the colors available (#26015) * [Timeline] Add support for position override on items (#25974) * [core] Remove deprecated innerRef prop (#26028) [core] Remove deprecated innerRef prop (#26028) * [theme] Rename `createMuiTheme` to `createTheme` (#25992) * [pickers] Remove redundant aria-hidden (#26014) * [internal][pickers] Remove unused styles (#26023) * [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017) * [DateRangePicker] Fix not being opened on click (#26016) * Inline classes * type -> interface * sort asc * default props are private * remove uneccesary type casting * follow convention * trigger pipeline Co-authored-by: Anshuman Pandey <54475686+anshuman9999@users.noreply.github.com> Co-authored-by: simonecervini <69400730+simonecervini@users.noreply.github.com> Co-authored-by: Matheus Wichman <matheushw@outlook.com> Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

github-actions bot mentioned this pull request Apr 26, 2021

Update snapshots for pr/25992 eps1lon/mui-scripts-incubator#2206

Closed

oliviertassinari added the breaking change Introduces changes that are not backward compatible. label Apr 26, 2021

m4theushw mentioned this pull request Apr 26, 2021

[RFC] Material-UI v5 🚀 #20012

Closed

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 27, 2021

m4theushw added 2 commits April 27, 2021 08:43

[theme] Rename createMuiTheme to createTheme

f9caa43

fix replace for cdn path

1d69eb5

m4theushw force-pushed the rename-createMuiTheme branch from 29c2fb6 to 1d69eb5 Compare April 27, 2021 11:47

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 27, 2021

rename url in color pages

5463139

m4theushw mentioned this pull request Apr 27, 2021

[theme] Deprecate createMuiTheme #26004

Merged

1 task

restore createMuiTheme

2b0097b

mnajdova reviewed Apr 28, 2021

View reviewed changes

mnajdova approved these changes Apr 28, 2021

View reviewed changes

oliviertassinari added deprecation New deprecation message. and removed breaking change Introduces changes that are not backward compatible. labels Apr 28, 2021

m4theushw added 2 commits April 28, 2021 14:17

Revert "fix replace for cdn path"

d9a6e69

This reverts commit 1d69eb5.

keep using createMuiTheme

5a44e9a

mnajdova merged commit 16e5d03 into mui:next Apr 29, 2021

eps1lon pushed a commit to siriwatknp/material-ui that referenced this pull request Apr 29, 2021

[theme] Rename createMuiTheme to createTheme (mui#25992)

684a0d5

m4theushw deleted the rename-createMuiTheme branch April 29, 2021 11:24

aleksanderbrymora mentioned this pull request Oct 15, 2021

[legacy-framework] createMuiTheme deprecation update blitz-js/blitz#2844

Closed

fzaninotto mentioned this pull request Dec 2, 2021

update docs & example : createMuiTheme is out of date marmelab/react-admin#6918

Merged

aleksanderbrymora mentioned this pull request Oct 15, 2021

[legacy-framework] createMuiTheme deprecation update blitz-js/blitz#2844

Closed

fzaninotto mentioned this pull request Dec 2, 2021

update docs & example : createMuiTheme is out of date marmelab/react-admin#6918

Merged

Uh oh!

Conversation

m4theushw commented Apr 26, 2021 • edited by oliviertassinari Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depreciations

Uh oh!

mui-pr-bot commented Apr 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliviertassinari commented Apr 26, 2021

Uh oh!

eps1lon commented Apr 27, 2021

Uh oh!

oliviertassinari commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m4theushw commented Apr 27, 2021

Uh oh!

mnajdova Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

mnajdova Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

m4theushw Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnajdova Apr 28, 2021

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnajdova left a comment

Choose a reason for hiding this comment

Uh oh!

mnajdova commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

m4theushw commented Apr 26, 2021 •

edited by oliviertassinari

Loading

mui-pr-bot commented Apr 26, 2021 •

edited

Loading

oliviertassinari commented Apr 27, 2021 •

edited

Loading

m4theushw Apr 28, 2021 •

edited

Loading

oliviertassinari Apr 28, 2021 •

edited

Loading