Skip to content

[TextField] Migrate OutlinedInput to emotion#24688

Merged
oliviertassinari merged 20 commits intomui:nextfrom
duganbrett:migrate-outlined-input
Feb 17, 2021
Merged

[TextField] Migrate OutlinedInput to emotion#24688
oliviertassinari merged 20 commits intomui:nextfrom
duganbrett:migrate-outlined-input

Conversation

@duganbrett
Copy link
Contributor

This PR migrates the OutlinedInput component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 29, 2021

@material-ui/core: parsed: +0.08% , gzip: +0.08%

Details of bundle changes

Generated by 🚫 dangerJS against 59ea06d

@oliviertassinari oliviertassinari added the scope: text field Changes related to the text field. label Jan 29, 2021
)}
classes={{
...classes,
root: clsx(classes.root, classes.underline),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed the underline classes in the useUtilityClasses above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I looked at this but I assumed this was here as an error. This shouldn't have an underline class.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 15, 2021
@duganbrett duganbrett force-pushed the migrate-outlined-input branch from f9fe959 to 7137c95 Compare February 15, 2021 21:41
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 15, 2021
@duganbrett duganbrett force-pushed the migrate-outlined-input branch from 36e1446 to ade290b Compare February 15, 2021 22:49
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR mui#24688
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR mui#24688
@oliviertassinari oliviertassinari self-assigned this Feb 16, 2021
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR mui#24688
@oliviertassinari
Copy link
Member

@duganbrett Thanks!

@duganbrett duganbrett deleted the migrate-outlined-input branch February 18, 2021 19:30
tchock added a commit to Bojagi/material-ui that referenced this pull request Mar 10, 2021
This is a copy of upstream PR mui#24688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: text field Changes related to the text field.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants