Merged
Conversation
|
@material-ui/core: parsed: +0.12% , gzip: +0.13% |
mnajdova
reviewed
Jan 22, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
Did a first round of review. Will do another one after these comments are resolved :)
ff2c8fe to
7366a0c
Compare
oliviertassinari
approved these changes
Jan 23, 2021
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
I'm not sure we needed to migrate it as we want to remove the components but it looks great :)
mnajdova
approved these changes
Jan 25, 2021
natac13
pushed a commit
to natac13/material-ui
that referenced
this pull request
Jan 25, 2021
eps1lon
pushed a commit
to eps1lon/material-ui
that referenced
this pull request
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the
Hiddencomponent (specifically,HiddenCss) to the new emotion format as a part of #24405.This component was very complex. I'm hoping I pulled it off properly!