[Breadcrumbs] Migrate to emotion by queengooborg · Pull Request #24522 · mui/material-ui

queengooborg · 2021-01-20T23:17:45Z

This PR migrates the Breadcrumbs component to the new emotion format as a part of #24405.

I have followed (at least) the PR section of the contributing guide.

mui-pr-bot · 2021-01-20T23:19:57Z

@material-ui/core: parsed: +0.29% , gzip: +0.20%

Generated by 🚫 dangerJS against 153fc5c

queengooborg · 2021-01-21T03:46:24Z

Looks like the failing test was probably a fluke? It's only failing on a specific Edgium version for an unrelated component.

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

packages/material-ui/src/Breadcrumbs/Breadcrumbs.test.js

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

queengooborg · 2021-01-21T17:05:50Z

Just did a conversion of the BreadcrumbCollapsed component. Since it's a private, internal component, I noticed that the codebase was a bit different than normal -- hope I did it right!

packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.d.ts

packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.js

packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.js

packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.d.ts

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

queengooborg · 2021-01-22T06:18:02Z

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

mnajdova · 2021-01-22T11:28:26Z

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

@oliviertassinari are we fine with this change?

packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

[Breadcrumbs] Migrate to emotion

449a845

oliviertassinari added the scope: breadcrumbs Changes related to the breadcrumbs. label Jan 20, 2021

oliviertassinari mentioned this pull request Jan 20, 2021

Migrate all components to emotion #24405

Closed

github-actions bot mentioned this pull request Jan 20, 2021

Update snapshots for pr/24522 eps1lon/mui-scripts-incubator#1738

Closed

queengooborg added 4 commits January 20, 2021 16:03

Breadcrumbs doesn't need to test theme variants

48dac4f

Resolve TS issues with sx prop

ecfc45c

Recompile docs + prototypes

12ef735

sx is optional

644497e

mnajdova reviewed Jan 21, 2021

View reviewed changes

oliviertassinari reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved

queengooborg added 6 commits January 21, 2021 08:23

Simplify styles for root slot

4188f3a

Remove redundant LI slot

4c13038

Fix styleProps

dcf69ce

Update tests

3e926b5

Update styleProps

67070d0

Remove redundant LI slot

59c6ca4

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 21, 2021

queengooborg and others added 4 commits January 21, 2021 08:45

Apply suggestions from code review

4721344

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

Merge branch 'next' into migrate/Breadcrumbs

4234049

Convert BreadcrumbCollapsed to emotion

1d17c05

Merge branch 'next' into migrate/Breadcrumbs

b53826c

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 21, 2021

mnajdova reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated Show resolved Hide resolved

"classes" is no longer required for BreadcrumbCollapsed

8ee9c98

oliviertassinari reviewed Jan 21, 2021

View reviewed changes

queengooborg and others added 2 commits January 21, 2021 09:43

Apply suggestions from code review

ff7d0c6

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js

2f6d270

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

mnajdova reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.d.ts Show resolved Hide resolved

mnajdova reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/breadcrumbsClasses.js Show resolved Hide resolved

mnajdova reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.js Outdated Show resolved Hide resolved

mnajdova reviewed Jan 21, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/breadcrumbCollapsedClasses.d.ts Outdated Show resolved Hide resolved

queengooborg and others added 2 commits January 21, 2021 10:25

Apply suggestions from code review

9c143e9

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

Remove unused variable

6329cad

mnajdova reviewed Jan 22, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js Outdated Show resolved Hide resolved

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved

queengooborg and others added 6 commits January 22, 2021 07:43

Update packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js

e46f357

Co-authored-by: Marija Najdova <mnajdova@gmail.com>

Include "expanded" in styleProps

ae1aef7

Merge branch 'next' into migrate/Breadcrumbs

be6f967

no need to rename the prop

57cb867

no need to clone the props

6cc5083

no use case for forward ref

c7e5d3d

oliviertassinari approved these changes Jan 23, 2021

View reviewed changes

oliviertassinari added 2 commits January 24, 2021 02:13

rerun ci

4003189

rerun ci

e7c7832

oliviertassinari assigned mnajdova Jan 24, 2021

mnajdova reviewed Jan 25, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved

Update packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

972829e

mnajdova reviewed Jan 25, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved

Update packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

6635d86

mnajdova approved these changes Jan 25, 2021

View reviewed changes

mnajdova reviewed Jan 25, 2021

View reviewed changes

packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved

Update packages/material-ui/src/Breadcrumbs/Breadcrumbs.js

153fc5c

mnajdova merged commit 27bbb5b into mui:next Jan 25, 2021

queengooborg deleted the migrate/Breadcrumbs branch January 25, 2021 07:46

natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021

[Breadcrumbs] Migrate to emotion (mui#24522)

614268e

eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021

[Breadcrumbs] Migrate to emotion (mui#24522)

5663d84

Uh oh!

Conversation

queengooborg commented Jan 20, 2021

Uh oh!

mui-pr-bot commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

queengooborg commented Jan 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

queengooborg commented Jan 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

queengooborg commented Jan 22, 2021

Uh oh!

mnajdova commented Jan 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mui-pr-bot commented Jan 20, 2021 •

edited

Loading