@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 219db8e

I have moved the deprecations to the v4-deprecations branch, so we could still cut releases from master.

Should I open PR towards that branch?

Should I open PR towards that branch?

I think so, I have changed the baseline branch

This is a breaking change (see marmelab/react-admin#6421). It was released in a minor release, which breaks exisiting apps.

Could this be reverted, or applied in a backwards compatible way?

This is a breaking change (see marmelab/react-admin#6421). It was released in a minor release, which breaks exisiting apps.

Could this be reverted, or applied in a backwards compatible way?

@fzaninotto what exactly broke? Could you provide a minimal reproduction using Material-UI components? If you are referring to the changes done in TablePaginationActions.js that is an internal component, and we do not guarantee that it will not contain breaking changes during a minor release.

You've changed the TablePagination props type, and this is a public component. It now requires a prop called onPageChange, which it didn't require before. So a call <TablePagination onChangePage={} /> will fail TS compilation, while it used to pass in the past. You've realized that its a breaking change while doing it (see first comment in this PR).

For a repro use case, see the attached react-admin issue.

same here. onChangePage was optional, onPageChange is required.

@ggascoigne The type change seems expected to me. We don't follow semver with the types (AFAIK).

The initial point #23789 (comment) seems different, a JS runtime issue. @mnajdova it seems we forgot to forward the old onChangePage prop to the <ActionsComponent /> slot.

Well I'm not going to argue that it isn't correct, just that I didn't expect that the interface to a public component to change in a breaking manner and not be called out. It was easy enough to fix once I found this PR.

I will add that I love this library and really appreciate all of the many hours of hard work that you all put into it.

How about we do this diff:

index b027226200..98770320d0 100644
--- a/packages/material-ui/src/TablePagination/TablePagination.d.ts
+++ b/packages/material-ui/src/TablePagination/TablePagination.d.ts
@@ -31,7 +31,7 @@ export interface TablePaginationTypeMap<P, D extends React.ElementType> {
        * @param {number} page The page selected.
        * @deprecated Use the onPageChange prop instead.
        */
-      onChangePage?: (event: React.MouseEvent<HTMLButtonElement> | null, page: number) => void;
+      onChangePage: (event: React.MouseEvent<HTMLButtonElement> | null, page: number) => void;
       onPageChange: (event: React.MouseEvent<HTMLButtonElement> | null, page: number) => void;
       /**
        * Callback fired when the number of rows per page is changed.
diff --git a/packages/material-ui/src/TablePagination/TablePaginationActions.d.ts b/packages/material-ui/src/TablePagination/TablePaginationActions.d.ts
index 17d76f48ea..be49a53bab 100644
--- a/packages/material-ui/src/TablePagination/TablePaginationActions.d.ts
+++ b/packages/material-ui/src/TablePagination/TablePaginationActions.d.ts
@@ -5,6 +5,8 @@ export interface TablePaginationActionsProps extends React.HTMLAttributes<HTMLDi
   backIconButtonProps?: Partial<IconButtonProps>;
   count: number;
   nextIconButtonProps?: Partial<IconButtonProps>;
+  // @deprecated Use the onPageChange prop instead.
+  onChangePage: (event: React.MouseEvent<HTMLButtonElement> | null, page: number) => void;
   onPageChange: (event: React.MouseEvent<HTMLButtonElement> | null, page: number) => void;
   page: number;
   rowsPerPage: number;
diff --git a/packages/material-ui/src/TablePagination/TablePaginationActions.js b/packages/material-ui/src/TablePagination/TablePaginationActions.js
index bbe0a95f0e..b009219e76 100644
--- a/packages/material-ui/src/TablePagination/TablePaginationActions.js
+++ b/packages/material-ui/src/TablePagination/TablePaginationActions.js
@@ -13,7 +13,8 @@ const TablePaginationActions = React.forwardRef(function TablePaginationActions(
     backIconButtonProps,
     count,
     nextIconButtonProps,
-    onPageChange,
+    onPageChange: onPageChangeProp,
+    onChangePage: onChangePageProp,
     page,
     rowsPerPage,
     ...other
@@ -21,6 +22,8 @@ const TablePaginationActions = React.forwardRef(function TablePaginationActions(

   const theme = useTheme();

+  const onPageChange = onPageChangeProp || onChangePageProp;
+
   const handleBackButtonClick = (event) => {
     onPageChange(event, page - 1);
   };

It should fix both the TypeScript regressions as well as the JS regression in the TablePaginationActions component.

@mnajdova We would also need to disable prop-type generation for onChangePage then, because otherwise, it won't displayed as required in the API docs. In any case, I think that the discussion should move to #27192.

Wait, in #23789 (comment) we have onPageChange and onChangePage required?

Wait, in #23789 (comment) we have onPageChange and onChangePage required?

They are both NOT required. oops you are correct, let me update.

I've moved the suggestion on the issue.